Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 654653 - Some CXXFLAGS is missing for non GNU_CXX compiler
: Some CXXFLAGS is missing for non GNU_CXX compiler
: regression
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All Solaris
: -- normal (vote)
: mozilla6
Assigned To: Ginn Chen
: Gregory Szorc [:gps]
Depends on:
Blocks: 650304
  Show dependency treegraph
Reported: 2011-05-03 23:50 PDT by Ginn Chen
Modified: 2011-05-04 00:41 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (881 bytes, patch)
2011-05-03 23:53 PDT, Ginn Chen
mh+mozilla: review+
Details | Diff | Splinter Review

Description Ginn Chen 2011-05-03 23:50:53 PDT
In Bug 650304, CXXFLAGS is setting to $_SAVE_CXXFLAGS if ac_cv_have_usable_char16_t is not "yes".

But _SAVE_CXXFLAGS is only set for GNU_CXX before the checking.
It will wash away some CXXFLAGS.
Comment 1 Ginn Chen 2011-05-03 23:53:49 PDT
Created attachment 529937 [details] [diff] [review]
Comment 2 Mike Hommey [:glandium] 2011-05-04 00:10:17 PDT
Comment on attachment 529937 [details] [diff] [review]

Review of attachment 529937 [details] [diff] [review]:

@@ +2983,5 @@
 if test "$ac_cv_have_usable_char16_t" = "yes"; then
+    if test "$GNU_CXX"; then

r=me with an "elif" instead of "else if" (and thus, one less "fi")

Note You need to log in before you can comment on or make changes to this bug.