The default bug view has changed. See this FAQ.

Some CXXFLAGS is missing for non GNU_CXX compiler

RESOLVED FIXED in mozilla6

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

({regression})

unspecified
mozilla6
All
Solaris
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
In Bug 650304, CXXFLAGS is setting to $_SAVE_CXXFLAGS if ac_cv_have_usable_char16_t is not "yes".

But _SAVE_CXXFLAGS is only set for GNU_CXX before the checking.
It will wash away some CXXFLAGS.
(Assignee)

Comment 1

6 years ago
Created attachment 529937 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #529937 - Flags: review?(benjamin)
Comment on attachment 529937 [details] [diff] [review]
patch

Review of attachment 529937 [details] [diff] [review]:

::: configure.in
@@ +2983,5 @@
 if test "$ac_cv_have_usable_char16_t" = "yes"; then
     AC_DEFINE(HAVE_CPP_CHAR16_T)
     HAVE_CPP_CHAR16_T=1
 else
+    if test "$GNU_CXX"; then

r=me with an "elif" instead of "else if" (and thus, one less "fi")
Attachment #529937 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/3ff945bdace7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.