65470 - bookmarks window updates

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

"bugzilla as a cheap alternative to traditional backup methods"

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Commence File Attachment, Part I (first cut) 

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks.js - the new bookmark management window.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksDD.js - drag and drop for the bookmarks window.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksOverlay.js - shared bookmarks utility functions

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksTree.js - tree-related bookmarks functions

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks.xul - the bookmarks management window

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksOverlay.xul - shared bookmarks content

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: modifications to treeBindings.xml (inline edit cell), xul.css (hook up cell + some resizable popup stuff + rules for template rules to shut up the frame constructor)

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: inline edit cell style rules for classic-win

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks-tree.css - rules for the tree widgets in bookmarks window/panel

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: personalToolbar.css - navigator specific bookmarks rules

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

OK, so this is a *preliminary cut*. I've included all of the files /diffs where 
files aren't appropriate, but no build magic, I'll leave that to the reader to 
set up for him/herself. 

Not all the functionality works yet. This is a work in progress. Almost all 
context menu functionality should work however as the new command system is 
working. Menuitems/accelerators won't until I set the bookmarksController up to 
pass through to my command system. 

Comment 13

[Fabian Guisset]

I installed the diffs/new files on build 2001011420 win32. Here are my first
impressions. Note that it's possible that I forgot a couple of things while
patching, so it might not be extremely accurate.
1) When launching Mozilla, I get "JS error : BookmarksTree is not defined,
line57 of bookmarks.js" in the console. line 56-57 : 
"BookmarksWindow.prototype = {
  __proto__: BookmarksTree.prototype,"
I'm not sure why bookmarks.js has to be loaded at startup, though.
2) Opening the Bookmarks Manager, I get no error (great!).
 Inline editing rocks and works perfectly. 
3) Drag and drop doesn't work. I get no error either, so I am guessing I did
something wrong when patching, or it's not hooked up yet.
4) Context menus's menuitems all show "null" as value, but of course there was
no diff/new file for bookmarks.properties, so it's kind of normal.
5) Menu items doesn't work, but you mentioned that above.
Hope this helps, this new bookmark manager looks extremely great!
Fabian.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

"1) When launching Mozilla, I get "JS error : BookmarksTree is not defined,
line57 of bookmarks.js" in the console. line 56-57 :"
Yes, I have not yet patched navigator or restructured the personal toolbar. In 
the old management system, all bm code was stored in bookmarks.js and this had 
to be loaded by navigator. Now shared code is located in bookmarksOverlay.js, 
which Navigator will be modified to load in an upcoming patch. The error is 
harmless so I haven't yet fixed it. 

"3) Drag and drop doesn't work. I get no error either, so I am guessing I did
something wrong when patching, or it's not hooked up yet."
The bookmarks window uses my updated drag and drop libraries, which aren't in 
the tree yet. See bugs 64722 and 64723, which have patches attached. Most 
importantly, you need nsDragAndDrop.js and nsTransferable.js. 

"4) Context menus's menuitems all show "null" as value, but of course there was
no diff/new file for bookmarks.properties, so it's kind of normal."
Oops, I'll attach that with the next set of patches. I also have a modified 
bookmarks.dtd

"5) Menu items doesn't work, but you mentioned that above."
I now have these mostly working with the command updater so things get 
disabled/enabled.

More patches coming soon. 

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

Second code drop. Comments after attachments

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks.js - the bookmarks window

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksDD.js - bookmarks drag and drop

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksOverlay.js - shared bookmarks code.

Comment 19

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksTree.js - bookmarks tree-related shared code.

Comment 20

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks.xul - the Bookmarks window

Comment 21

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksOverlay.xul - shared content

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks.dtd - strings

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksOverlay.dtd - more strings

Comment 24

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmark.properties - even more strings

Comment 25

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: global changes, inline edit cell, xul.css hookup, stringbundle changes, new menubutton type.

Comment 26

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: Classic changes for inline edit cell, new menubutton widget

Comment 27

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks-tree.css tree bookmarks rules

Comment 28

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmark-item-updated.gif - updated bookmark icon

Comment 29

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: personalToolbar.css - personal toolbar bookmarks rules

Comment 30

[Ben Goodger (use ben at mozilla dot org for email)]

OK I think this is everything.

this time around, we have a toolbar, with a combo button for new items, the 
three buttons to the left (properties, rename, delete) used to work but they 
regressed recently on me. <Del> is buggy, doesn't always work. Tip: if you 
accidentally delete too much (which can happen!) go to your debug console window 
and hit Ctrl+C, or force quit the app. This way, changes aren't flushed to disk 
and you can restart to restore your bookmarks. 

Also implemented is a quickfile button. you can select items in the list and use 
the file button's dropdown menu (a new widget) to file in a different folder, or 
drag the selection onto the button and down into the menu (!). This action is 
also somewhat spotty, but it works about 90% of the time. 

Inline create new folder now works, sometimes it doesn't create a new inline 
edit row. Inline create new bookmark is coded but doesn't work yet. You need to 
apply the C++ part of the patch attached to 27495 to get this to work properly. 

That's it for now, more later.

Comment 31

[Fabian Guisset]

Adding self to CC so I can get a lot of spam while i'm skiing next week.
First impressions : New toolbar looks impressive, excellent work. All the
properties/dtd files are ok, I get menu item values now. Comments/Bugs :
1) The properties and rename shortcut don't work. No error in console.
2) Chosing the "copy" menu item in the edit menu crashed Mozilla.
3) I get a few "srGetStrBundle not defined" errors. Your probably forgot some
parenthesis or something like that.
4) I still get the BookmarksTree error, line 157 of bookmarks.js
5) The New Bookmark shortcut in the toolbar really creates a new Folder. If I
edit it inline, then type enter, the folder disappears. Also after it
disappears, when clicking anywhere, it edits the previous bookmark inline.
6) New separator doesn't work.
7) Sorting by clicking on the columns doesn't work. I get a "debug is not
defined" output in the console.
8) The "File Bookmark" feature rocks and works perfectly! Now if only you could
hook it up in the Bookmarks menu of the Personnal Toolbar and in the Bookmarks
Toolbar of the main menubar!

Disclaimer : I installed Jag's patch for the XBL-ified browser before using
these patches, so I may have totally screwed it, if the bugs I reported work
fine on your machine (which I doubt since you also tried Jag's patch), please
ignore them ;)

Keep up the excellent work!
Fabian.

Comment 32

[Fabian Guisset]

Oh and a last trivial thing.. in the patch for stringbundleBindings.xml, line52-61 :
"var applicationLocale = null" . There is a missing semicolon.

Comment 33

[Ben Goodger (use ben at mozilla dot org for email)]

nsbeta1, final patches coming soon. 

Comment 34

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: ======================================================

Comment 35

[Blake Ross]

r=blake on last patch
check this baby in.

Comment 36

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks.xul (file)

Comment 37

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks.js (file)

Comment 38

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksTree.js (file)

Comment 39

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksOverlay.js

Comment 40

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksOverlay.xul (file)

Comment 41

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: pref-bookmarks.xul (file)

Comment 42

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: addBookmark.xul (file)

Comment 43

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: addBookmark.js (file)

Comment 44

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bm-props.xul (file)

Comment 45

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bm-props.js (diff)

Comment 46

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarksDD.js (file)

Comment 47

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: rudimentary hacking to the bookmarks service (to be repaired in .9)

Comment 48

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: addBookmark.dtd (file)

Comment 49

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: pref-bookmarks.dtd file)

Comment 50

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: locale stuff for bookmarks window

Comment 51

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: required changes to navigator

Comment 52

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: changes to global

Comment 53

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: classic changes

Comment 54

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: classic\navigator\personalToolbar.css (file)

Comment 55

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: bookmarks-tree.css (file)

Comment 56

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: prefwindow changes

Comment 57

[David Hyatt]

Fixed. (ben, not hyatt) 

Comment 58

[Claudius Gayle]

rubber-stamping VERIFIED Fixed