Closed Bug 654733 Opened 11 years ago Closed 11 years ago

Stop using 'computer' in offline storage notifications

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: wesj)

Details

Attachments

(2 files)

We use the word 'computer' for some of the offline storage notifications: app cache and indexedDB

Let's make it more mobile centric

http://mxr.mozilla.org/mozilla-central/source/mobile/locales/en-US/chrome/browser.properties
Attached patch PatchSplinter Review
5 min fix. Is there anything else you know of mfinkle?
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
Attachment #530054 - Flags: review?(mark.finkle)
Comment on attachment 530054 [details] [diff] [review]
Patch

We need madhava to sign off on this too
Attachment #530054 - Flags: ui-review?(madhava)
Attachment #530054 - Flags: review?(mark.finkle)
Attachment #530054 - Flags: review+
Attachment #530054 - Flags: ui-review?(madhava) → ui-review+
pushed: http://hg.mozilla.org/mozilla-central/rev/8d0ca70728ff
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Can somebody verify this please?
note that the l10n community will not notice this change because there is no entity change. if it is important that it also change in other languages who use different words for computer and device you need to change the entity so the l10n dashboard will pick it up. or at least leave a note in the l10n newsgroup
http://vingtetun.org/todo will show this.  Also looking at the mobile/locales/en-US/chrome/browser.properties.

Posted message at http://groups.google.com/group/mozilla.dev.l10n/topics

Verified : 
Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110513 Firefox/6.0a1 Fennec/6.0a1
Device: Droid 2 
OS: Android 2.2
Status: RESOLVED → VERIFIED
Reopening.

Mark, this patch shouldn't have gotten an r+ from you, honestly.

A note to .l10n isn't the right way forward here. I won't have time to back this out until Monday, so you'll have time to fix the keynames 'til then.

Sorry for the short note, gotta catch a plane in a few.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Whiteboard: [needs backout]
As Pike said, this patch lacks 2 things:

1- changing the names of the entities (posting about this in dev-l10n isn't sufficient for various reasons).

2- There are other related uses of the term 'computer' such as in overrides/*. You should probably change those too.
(In reply to comment #8)
> 2- There are other related uses of the term 'computer' such as in
> overrides/*. You should probably change those too.

The neterror pages are being redesigned in bug 582048. Similarly the antiphishing ui is being redesigned in bug 651860. The only other references I see are about:home "Tabs from other computers", the password manager (which isn't supported in Fennec and will require changes in toolkit code), and a few various sync strings which shouldn't change:
"From a Firefox Sync connected computer..."
"I'm not near my computer..."
"Please update Firefox on your other computer(s)..."

Changing entity names will require some code changes in ContentPermissionPrompt (or changing the entity names for every single of the "siteWantsTo" entity). Writing some test pages now.
patch for entities coming up...
Whiteboard: [needs backout]
This patch resets the entity names and makes the non-trivial code changes needed to support those changes.

Let me repeat something I have said in the past: Forcing code changes for string changes is _wrong_! There is no way I could ever feel good about a patch like this. It will require a full QA cycle of functional testing over the affected areas, if those areas can be "well scoped".

Surely there is some way our L10N tools can use something other than entity name to key on changes. Can't we store a hash of the string itself?
Attachment #532443 - Flags: review?(wjohnston)
Attachment #532443 - Flags: review?(wjohnston) → review+
pushed:
http://hg.mozilla.org/mozilla-central/rev/8e093acb3867
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Verified fixed
Mozilla/5.0 (Android; Linux armv7l; rv:6.0a1) Gecko/20110518 Firefox/6.0a1 Fennec/6.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.