654743 - Cleanup debug statments in the editor

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Ludovic Hirlimann [:Usul]]

Attachment: cleanup debug statments

Some file have DEBUG_username in them.

Remove that debug code to clean up the tree.

Comment 1

[Ludovic Hirlimann [:Usul]]

Attachment: More complete cleanups with NS_DEBUGs too

Comment 2

[David :Bienvenu]

Comment on attachment 530626 [details] [diff] [review]
More complete cleanups with NS_DEBUGs too

No need for the braces here, anymore:

         if (nsMsgIsLocalFile(url.get()))
       {
         mCompFieldLocalAttachments++;
-#if defined(DEBUG_ducarroz)
-          printf("Counting LOCAL attachment %d: %s\n", mCompFieldLocalAttachments, url.get());
-#endif
       }
       else    // This is a remote URL...
       {
         mCompFieldRemoteAttachments++;
-#if defined(DEBUG_ducarroz)
-          printf("Counting REMOTE attachment %d: %s\n", mCompFieldRemoteAttachments, url.get());
-#endif
       }


/**** I think this should just be replaced with
  DoFcc();

Because the returns aren't needed, nor is the return code.

   nsresult retCode = DoFcc();
   if (NS_FAILED(retCode))
   {
-#ifdef NS_DEBUG
-  printf("\nDoDeliveryExitProcessing(): DoFcc() call Failed!\n");
-#endif
     return;
   }
   else
   {
     // Either we started the copy...cleanup happens later...or cleanup will
     // be take care of by a listener...
     return;
   }

r=me, with those comments addressed.

Comment 3

[Ludovic Hirlimann [:Usul]]

Attachment: addressing review coments

Patch ready for checking

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/cbfe8824fac8