TM: Give Shape::shape and Shape::id better names

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cdleary, Assigned: cdleary)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

Created attachment 530105 [details] [diff] [review]
Change shape identifiers.

Dumb identifier change patch, but got tired of looking at shape->shape. I liked jorendorff's suggestion of Shape::shapeid and Shape::propid.
Attachment #530105 - Flags: review?(jorendorff)
Comment on attachment 530105 [details] [diff] [review]
Change shape identifiers.

Review of attachment 530105 [details] [diff] [review]:

Nice. r=me.

::: js/src/jsgcmark.cpp
@@ +656,5 @@
 void
 MarkChildren(JSTracer *trc, const Shape *shape)
 {
 restart:
+    MarkId(trc, shape->propid, "id");

Here it would make sense to change the string "id" to "propid" too.
Attachment #530105 - Flags: review?(jorendorff) → review+
http://hg.mozilla.org/tracemonkey/rev/f0329a9811c9
Whiteboard: fixed-in-tracemonkey
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/f0329a9811c9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.