Last Comment Bug 654792 - TM: Give Shape::shape and Shape::id better names
: TM: Give Shape::shape and Shape::id better names
Status: RESOLVED FIXED
fixed-in-tracemonkey
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Chris Leary [:cdleary] (not checking bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-04 11:48 PDT by Chris Leary [:cdleary] (not checking bugmail)
Modified: 2011-05-10 15:13 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Change shape identifiers. (65.29 KB, patch)
2011-05-04 11:48 PDT, Chris Leary [:cdleary] (not checking bugmail)
jorendorff: review+
Details | Diff | Review

Description Chris Leary [:cdleary] (not checking bugmail) 2011-05-04 11:48:03 PDT
Created attachment 530105 [details] [diff] [review]
Change shape identifiers.

Dumb identifier change patch, but got tired of looking at shape->shape. I liked jorendorff's suggestion of Shape::shapeid and Shape::propid.
Comment 1 Jason Orendorff [:jorendorff] 2011-05-04 11:59:35 PDT
Comment on attachment 530105 [details] [diff] [review]
Change shape identifiers.

Review of attachment 530105 [details] [diff] [review]:

Nice. r=me.

::: js/src/jsgcmark.cpp
@@ +656,5 @@
 void
 MarkChildren(JSTracer *trc, const Shape *shape)
 {
 restart:
+    MarkId(trc, shape->propid, "id");

Here it would make sense to change the string "id" to "propid" too.
Comment 2 Chris Leary [:cdleary] (not checking bugmail) 2011-05-04 12:05:57 PDT
http://hg.mozilla.org/tracemonkey/rev/f0329a9811c9
Comment 3 Chris Leary [:cdleary] (not checking bugmail) 2011-05-10 15:13:27 PDT
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/f0329a9811c9

Note You need to log in before you can comment on or make changes to this bug.