Closed
Bug 654792
Opened 14 years ago
Closed 14 years ago
TM: Give Shape::shape and Shape::id better names
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: cdleary, Assigned: cdleary)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
65.29 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Dumb identifier change patch, but got tired of looking at shape->shape. I liked jorendorff's suggestion of Shape::shapeid and Shape::propid.
Attachment #530105 -
Flags: review?(jorendorff)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 530105 [details] [diff] [review]
Change shape identifiers.
Review of attachment 530105 [details] [diff] [review]:
Nice. r=me.
::: js/src/jsgcmark.cpp
@@ +656,5 @@
void
MarkChildren(JSTracer *trc, const Shape *shape)
{
restart:
+ MarkId(trc, shape->propid, "id");
Here it would make sense to change the string "id" to "propid" too.
Attachment #530105 -
Flags: review?(jorendorff) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 3•14 years ago
|
||
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/f0329a9811c9
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•