65480 - prefs advanced description wording

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Ben Bucksch (:BenB)]

Prefs Advanced:
Main pane:
"Checked items are automatically enabled when you visit web pages that use them.
If you uncheck an item, pages may load faster but some functionality will be
limited."

s/load faster/increase security or privacy/

Software Installation:
"Enable software installation. (You will be prompted for each update.)"

s/for/before/

Will attach patch. Matt, please r=.

Comment 1

[Ben Bucksch (:BenB)]

Oh, I'll add the following patch here, too:

Remove the brandname before "Internet Keywords" in the Smart Browsing pane.
Neither "Mozilla Internet Keywords" nor "Beonex Internet Keywords" makes sense -
this is Netscape-only stuff.

Comment 2

[Ben Bucksch (:BenB)]

Attachment: Fix, version 1

Comment 3

[Matthew T (active 1999-2002)]

In bug 55614 I suggest changing `Enable features which help to interpret web 
pages' to `Advanced options', and removing the meaningless and untrue `If you 
uncheck an item, pages may load faster but some functionality will be limited' 
string entirely.

Comment 4

[Ben Bucksch (:BenB)]

Well, "some functionality will be limited" is very true and the user should be
aware of that.

Example: Many users (including a press reviewer) complained that they couldn't
install Java for Beonex Comm. (made availbale as add-on via a webpage), becaus
ethey were unaware that disableing "Software installation and updates" would
inhibit this. You can argue about the meaningfulness of that pref, but similar
problems could certainly arise with disabled JS.

Comment 5

[Matthew T (active 1999-2002)]

Ok, but at the very least change `some functionality will be limited' to `some 
Web pages may not work as intended'. Having the word `functionality' in the UI 
is embarrassing.

Comment 6

[Ben Bucksch (:BenB)]

> at the very least change `some functionality will be limited' to `some
> Web pages may not work as intended'.

Fine with me, but please add that to the other bug - I don't want to create new
patches.

> Having the word `functionality' in the UI is embarrassing.

Out of curiosity: What's wrong with it?

Comment 7

[Ben Bucksch (:BenB)]

Nobody reviewd so far :-(, so I have to move to Mozilla 0.9. Please review!

Comment 8

[Ben Bucksch (:BenB)]

[e-mail], please review.

Comment 9

[matt]

r=matt

Comment 10

[Matthew T (active 1999-2002)]

> Out of curiosity: What's wrong with [`functionality']?

<http://dack.com/web/bullshit.html>. Note that `content' is also in that list,
so your patch makes things worse rather than better.

Please just delete that sentence, because it's lying. If it was true that
`Checked items are automatically enabled when you visit content that uses them',
Mozilla would turn the prefs back on as soon as you turned them off, so it would
be useless to have them at all.

Please also delete the `Enable features that help interpret web pages' groupbox,
because that's lying as well -- Java doesn't help interpret Web pages, and FTP
password doesn't apply to the Web at all.

Comment 11

[Christopher Hoess (gone)]

Attachment: "Death with dignity" for Advancec

Patch as requested by mpt.

Comment 12

[Stephen Walker]

Comment on attachment 72913 [details] [diff] [review]
"Death with dignity" for Advancec

r=walk84

Comment 13

[Ben Bucksch (:BenB)]

> > Out of curiosity: What's wrong with [`functionality']?
> <http://dack.com/web/bullshit.html>.

mpt, this is no explanation, just somebody else claiming the same.

Christopher, can you please attach a diff -uw?
Do you want to take this?

Comment 14

[Ben Bucksch (:BenB)]

not sure, what to do with this bug. choess, do you want to take it? should I
check in the patch?

Comment 15

[Andrew Hagen]

This bug seems to conflict with bug 117371. Should one be a dupe of the other?

Comment 16

[Peter Weilbacher]

*** Bug 117371 has been marked as a duplicate of this bug. ***

Comment 17

[Giacomo Magnini]

Attachment: Updated patch.

Most of the previous patch does not apply anymore.
Fix the wording in smat_browsing and smartupdate pref panels to close this bug.

Comment 18

[Ian Neal]

Comment on attachment 209434 [details] [diff] [review]
Updated  patch.

r=me, a=me for SM1.1, too late for SM1.0

Comment 19

[Ian Neal]

Comment on attachment 209434 [details] [diff] [review]
Updated  patch.

okay, I've persuaded that it's not too big an issue so just need one more a= for SM1.0 plus needs the late-l0n keyword plus announcing.

Comment 20

[Robert Kaiser]

Comment on attachment 209434 [details] [diff] [review]
Updated  patch.

a=me given the keyword and m.d.l10n shouting ;-)

Comment 21

[Stefan [:stefanh]]

--> Giacomo.

Comment 22

[Giacomo Magnini]

Announced, please check this thing in and kill another bug (5 years old only!).

Comment 23

[Robert Kaiser]

checked into trunk and both branches, thanks for fixing it!

Comment 24

[Stefan [:stefanh]]

You could have removed "Internet Keywords" at the beginning of the sentence - it's already there in the header label :-P