warning C4509: nonstandard extension used: 'PluginWindowEvent::Run' uses SEH and 'inst' has destructor

RESOLVED FIXED in mozilla9

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: RyanVM, Assigned: jimm)

Tracking

(Blocks 1 bug)

Trunk
mozilla9
x86
Windows 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

MSVC 2010 SP1 complains about this. Looks possibly troublesome.

c:/mozbuild/mozilla-central/dom/plugins/base/nsPluginNativeWindowWin.cpp(592) : warning C4509: nonstandard extension used: 'PluginWindowEvent::Run' uses SEH and 'inst' has destructor
	c:/mozbuild/mozilla-central/dom/plugins/base/nsPluginNativeWindowWin.cpp(592) : see declaration of 'inst'
Posted patch patchSplinter Review
Thought we dropped all the exception handling in the old plugin code. I guess there's still some of it left hanging around.
Assignee: nobody → jmathies
Attachment #534071 - Flags: review?(benjamin)
Comment on attachment 534071 [details] [diff] [review]
patch

the try-safe stuff is preffed off by default now but not removed, it's on my list of things to do
Attachment #534071 - Flags: review?(benjamin) → review+
I presume this makes the |NS_ENSURE_TRUE(aInst, NS_ERROR_NULL_POINTER)|, here: http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginNativeWindowWin.cpp#182
...redundant?

Other than that, happy for me to land this? (Attempting to work my way through the build warnings meta dependants, starting with those with patches).

In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> the try-safe stuff is preffed off by default now but not removed, it's on my
> list of things to do

Happy for me to file a bug on removing it?
(In reply to Ed Morley [:edmorley] from comment #3)
> I presume this makes the |NS_ENSURE_TRUE(aInst, NS_ERROR_NULL_POINTER)|,
> here:
> http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/
> nsPluginNativeWindowWin.cpp#182
> ...redundant?

I don't see how these changes insure GetPluginInstance can't return null.

> Other than that, happy for me to land this? 

sure.
(In reply to Jim Mathies [:jimm] from comment #4)
> (In reply to Ed Morley [:edmorley] from comment #3)
> > I presume this makes the |NS_ENSURE_TRUE(aInst, NS_ERROR_NULL_POINTER)|,
> > here:
> > http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/
> > nsPluginNativeWindowWin.cpp#182
> > ...redundant?
> 
> I don't see how these changes insure GetPluginInstance can't return null.

Only because aInst didn't appear to be used post patch, but I'm probably reading it wrong.
https://hg.mozilla.org/mozilla-central/rev/fbc0c5c938a9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.