654893 - Many warning C4996: '[...]': was declared deprecated in xpcprivate.h

Status: RESOLVED WORKSFORME

(Core :: XPConnect, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

This is a very spammy build warning currently using MSVC 2010 SP1.

c:\mozbuild\mozilla-central\js\src\xpconnect\src\xpcprivate.h(618) : warning C4996: 'nsIXPConnect::SetSafeJSContextForCurrentThread': was declared deprecated
        c:\mozbuild\mozilla-central\objdir-fx\dist\include\nsIXPConnect.h(922) : see declaration of 'nsIXPConnect::SetSafeJSContextForCurrentThread'
c:\mozbuild\mozilla-central\js\src\xpconnect\src\xpcprivate.h(3860) : warning C4996: 'nsIXPCComponents::LookupMethod': was declared deprecated
        c:\mozbuild\mozilla-central\objdir-fx\dist\include\xpccomponents.h(824) : see declaration of 'nsIXPCComponents::LookupMethod'
c:\mozbuild\mozilla-central\js\src\xpconnect\src\xpcprivate.h(3860) : warning C4996: 'nsIXPCComponents::ReportError': was declared deprecated
        c:\mozbuild\mozilla-central\objdir-fx\dist\include\xpccomponents.h(827) : see declaration of 'nsIXPCComponents::ReportError'
c:\mozbuild\mozilla-central\js\src\xpconnect\src\xpcprivate.h(618) : warning C4996: 'nsIXPConnect::SyncJSContexts': was declared deprecated
        c:\mozbuild\mozilla-central\objdir-fx\dist\include\nsIXPConnect.h(891) : see declaration of 'nsIXPConnect::SyncJSContexts'

Comment 1

[Benjamin Smedberg]

This is exactly why [deprecated] is completely useless with MSVC and we should turn it off on Windows: we get the compiler warnings for the *implementation* of the methods, not just the callers.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

These warnings are gone.