Closed Bug 654929 Opened 9 years ago Closed 9 years ago

XPConnectJSMjit/JSTjit should be used only within #ifdef JS_METHODJIT/JS_TRACER

Categories

(Core :: JavaScript Engine, defect)

Sun
OpenBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: gaston, Unassigned)

Details

Attachments

(1 file)

Landing of https://bugzilla.mozilla.org/show_bug.cgi?id=633653 broke OpenBSD/sparc64 (and maybe others) non-methodjit non-tracejit builds.

js/src/xpconnect/src/xpcjsruntime.cpp:1484: error: expected type-specifier before 'MemoryReporter_XPConnectJSMjitCode'
js/src/xpconnect/src/xpcjsruntime.cpp:1484: error: expected `)' before 'MemoryReporter_XPConnectJSMjitCode'

Etc etc, same errors for JSMjitdata, JSTjitCode, JSTjitDataAllocatorsMain, JSTjitDataAllocatorsReserve
The attached patch should fix the issue, confirmation as soon as my build finishes.
Attachment #530248 - Flags: review?(nnethercote)
For the record, see bottom of http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/13/steps/build/logs/stdio for the complete buildlog failure.
Comment on attachment 530248 [details] [diff] [review]
Add #ifdef JS_METHODJIT/JS_TRACER where appropriate

Review of attachment 530248 [details] [diff] [review]:

Thanks for fixing my error! :)
Attachment #530248 - Flags: review?(nnethercote) → review+
My OpenBSD/sparc64 build is successful with the aforementioned patch, so setting checkin-needed.
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/6beb0ffbdf98
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [fixed-in-cedar]
http://hg.mozilla.org/mozilla-central/rev/6beb0ffbdf98
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.