Last Comment Bug 654929 - XPConnectJSMjit/JSTjit should be used only within #ifdef JS_METHODJIT/JS_TRACER
: XPConnectJSMjit/JSTjit should be used only within #ifdef JS_METHODJIT/JS_TRACER
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: Sun OpenBSD
: -- normal (vote)
: mozilla6
Assigned To: general
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-04 23:53 PDT by Landry Breuil (:gaston)
Modified: 2011-05-06 21:22 PDT (History)
0 users
bzbarsky: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add #ifdef JS_METHODJIT/JS_TRACER where appropriate (4.22 KB, patch)
2011-05-04 23:55 PDT, Landry Breuil (:gaston)
n.nethercote: review+
Details | Diff | Review

Description Landry Breuil (:gaston) 2011-05-04 23:53:31 PDT
Landing of https://bugzilla.mozilla.org/show_bug.cgi?id=633653 broke OpenBSD/sparc64 (and maybe others) non-methodjit non-tracejit builds.

js/src/xpconnect/src/xpcjsruntime.cpp:1484: error: expected type-specifier before 'MemoryReporter_XPConnectJSMjitCode'
js/src/xpconnect/src/xpcjsruntime.cpp:1484: error: expected `)' before 'MemoryReporter_XPConnectJSMjitCode'

Etc etc, same errors for JSMjitdata, JSTjitCode, JSTjitDataAllocatorsMain, JSTjitDataAllocatorsReserve
Comment 1 Landry Breuil (:gaston) 2011-05-04 23:55:09 PDT
Created attachment 530248 [details] [diff] [review]
Add #ifdef JS_METHODJIT/JS_TRACER where appropriate

The attached patch should fix the issue, confirmation as soon as my build finishes.
Comment 2 Landry Breuil (:gaston) 2011-05-04 23:58:21 PDT
For the record, see bottom of http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/13/steps/build/logs/stdio for the complete buildlog failure.
Comment 3 Nicholas Nethercote [:njn] (on vacation until July 11) 2011-05-05 00:03:27 PDT
Comment on attachment 530248 [details] [diff] [review]
Add #ifdef JS_METHODJIT/JS_TRACER where appropriate

Review of attachment 530248 [details] [diff] [review]:

Thanks for fixing my error! :)
Comment 4 Landry Breuil (:gaston) 2011-05-05 06:51:58 PDT
My OpenBSD/sparc64 build is successful with the aforementioned patch, so setting checkin-needed.
Comment 5 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-05-05 19:58:46 PDT
http://hg.mozilla.org/projects/cedar/rev/6beb0ffbdf98
Comment 6 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-05-06 21:22:06 PDT
http://hg.mozilla.org/mozilla-central/rev/6beb0ffbdf98

Note You need to log in before you can comment on or make changes to this bug.