Closed
Bug 654934
Opened 14 years ago
Closed 14 years ago
ProxyObject::callProperty should not heap-allocate its arguments array
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lhansen, Assigned: lhansen)
References
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
Details | Diff | Splinter Review |
The arguments array should be allocated by means of VMPI_alloca. Presumably the heap allocation is an artifact of the code coming in from Player glue where VMPI_alloca may not be (easily?) available. I should have caught this in the review.
|
||
Comment 1•14 years ago
|
||
VMPI_alloca is available in Player code; this code predates VMPI_alloca's existence, and was probably never retrofitted.
|
Assignee | |
Comment 2•14 years ago
|
||
Assignee: stejohns → lhansen
Attachment #531336 -
Flags: review?(stejohns)
|
||
Comment 3•14 years ago
|
||
changeset: 6298:9d34c630ac8e
user: Lars T Hansen <lhansen@adobe.com>
summary: Fix 654934 - ProxyObject::callProperty should not heap-allocate its arguments array (review pending)
http://hg.mozilla.org/tamarin-redux/rev/9d34c630ac8e
|
|
Assignee | |
Comment 4•14 years ago
|
||
Pushed with review pending (after testing), because it seems like a no-brainer.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #531336 -
Flags: review?(stejohns) → review?(fklockii)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #531336 -
Flags: review?(fklockii)
|
|
||
Comment 5•14 years ago
|
||
pushed to tr-serrano as 6310:2ed87b807bbe
You need to log in
before you can comment on or make changes to this bug.
Description
•