PGO breaks Linux crash reports

RESOLVED FIXED in mozilla6

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla6
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 530275 [details] [diff] [review]
Remove -freorder-blocks-and-partition from PGO build options

I isolated the lack of DW_AT_low_pc and DW_AT_high_pc from bug 654595 as a gcc 4.5 bug with -freorder-blocks-and-partition (4.4 is also affected, for that matter). gcc 4.6 apparently doesn't have this problem.

The problem is simply reproducible with this simple source code:
  int foo() { return 0; }

Compiled with gcc -o foo.o -c foo.c -g -freorder-blocks-and-partition

I still think we should fix bug 654595 on the dump_syms end, thus filing this separated bug to use as a workaround until we fix bug 654595.
(Assignee)

Comment 1

6 years ago
Created attachment 530277 [details] [diff] [review]
Remove -freorder-blocks-and-partition from PGO build options

We also need nsprpub/configure to be updated, obviously.
Assignee: nobody → mh+mozilla
Attachment #530275 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #530277 - Attachment is obsolete: true
(Assignee)

Comment 2

6 years ago
Created attachment 530348 [details] [diff] [review]
Remove -freorder-blocks-and-partition from PGO build options

New version doing the very same, but without touching nsprpub/
Attachment #530348 - Flags: review?(ted.mielczarek)
Comment on attachment 530348 [details] [diff] [review]
Remove -freorder-blocks-and-partition from PGO build options

Review of attachment 530348 [details] [diff] [review]:

::: config/nspr/Makefile.in
@@ +58,5 @@
 # Copy NSPR to the SDK
 ABS_DIST = $(call core_abspath,$(DIST))
 
 libs::
+	$(MAKE) -C $(DEPTH)/nsprpub PROFILE_USE_CFLAGS="$(PROFILE_USE_CFLAGS)"

We can revert this bit after we land NSPR changes, right? Can you file another bug on the NSPR changes, and mention it in a comment here?
Attachment #530348 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> Comment on attachment 530348 [details] [diff] [review] [review]
> Remove -freorder-blocks-and-partition from PGO build options
> 
> Review of attachment 530348 [details] [diff] [review] [review]:
> 
> ::: config/nspr/Makefile.in
> @@ +58,5 @@
>  # Copy NSPR to the SDK
>  ABS_DIST = $(call core_abspath,$(DIST))
> 
>  libs::
> +    $(MAKE) -C $(DEPTH)/nsprpub PROFILE_USE_CFLAGS="$(PROFILE_USE_CFLAGS)"
> 
> We can revert this bit after we land NSPR changes, right? Can you file another
> bug on the NSPR changes, and mention it in a comment here?

Filed bug 655058. By "here" you mean here, or in the patch? (we can revert all config/nspr/* changes when the nspr change lands)
In a comment in that bit of the patch, I mean.
(Assignee)

Comment 6

6 years ago
Created attachment 530363 [details] [diff] [review]
Remove -freorder-blocks-and-partition from PGO build options
(Assignee)

Updated

6 years ago
Attachment #530348 - Attachment is obsolete: true
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/mozilla-central/rev/afcca618a5a4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.