Add a -moz-orient CSS property

RESOLVED FIXED in mozilla6

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

({dev-doc-complete})

Trunk
mozilla6
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 530359 [details] [diff] [review]
Patch v1

It's needed by bug 638540 and very similar to -moz-box-orient.
Attachment #530359 - Flags: review?(dbaron)
(Assignee)

Updated

6 years ago
Attachment #530359 - Flags: review?(bzbarsky)
(Assignee)

Updated

6 years ago
Attachment #530359 - Flags: review?(roc)
(Assignee)

Comment 1

6 years ago
If one of you think he can handle the review in a few days, could he cancel the other review requests?
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
Comment on attachment 530359 [details] [diff] [review]
Patch v1

r=me
Attachment #530359 - Flags: review?(roc)
Attachment #530359 - Flags: review?(dbaron)
Attachment #530359 - Flags: review?(bzbarsky)
Attachment #530359 - Flags: review+
Why do we want a new CSS property for this?
If it's only for the progress element, I think -moz-orient is too generic a name. How about -moz-progress-orient? Or how about just reusing -moz-box-orient? Does Webkit have a version of this, and what did they call it?

Updated

6 years ago
Keywords: dev-doc-needed
(Assignee)

Updated

6 years ago
Whiteboard: [needs review] → [ready to land][waits for dependencies]
(Assignee)

Comment 5

6 years ago
(In reply to comment #3)
> Why do we want a new CSS property for this?

That was the conclusion of the discussion in the CSS WG mailing list: we (you, Boris and I) had decided to use an HTML attribute and someone pointed that using a CSS property might be better (see the discussion for more details).

(In reply to comment #4)
> If it's only for the progress element, I think -moz-orient is too generic a
> name. How about -moz-progress-orient? Or how about just reusing
> -moz-box-orient? Does Webkit have a version of this, and what did they call
> it?

This is going to be used for <input type='range'> and <meter>. Webkit doesn't have such a property.
IMO, it would be better to make -moz-box-orient merged into -moz-orient instead of the opposite. Though, both are prefixed so we can see that later, can't we?
That www-style thread didn't really have a conclusion, but I can see that it drifted towards having explicit orientation control using a property.

Is there a reason to not just reuse box-orient here?
(Assignee)

Comment 7

6 years ago
(In reply to comment #6)
> Is there a reason to not just reuse box-orient here?

If you guys believe we should just use box-orient, I will follow you.
Boris and David, what's your opinion?
That seems fine to me.
(Assignee)

Comment 9

6 years ago
To me, box-orient seems a misleading name given that box-* properties are used for the box model and here, it's not really related to it AFAICT. In addition, box-orient accept four values and two of them would have no meaning for the form widgets. And, in the future, we might want to add new values to -moz-orient (like vertical but beginning from the top), which might not work with box-orient.
Those are good points.

I think I'll leave it up to David to decide what to do here :-).
(Assignee)

Comment 11

6 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/a756a95aaa31

David, if you think we should remove this property and use -moz-box-orient instead, let me know and I will back out this patch.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
Documented:

https://developer.mozilla.org/en/CSS/orient

And mentioned on Firefox 6 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.