655125 - [stage] Admin page 500's if no marks have been flagged - /#/moderate/

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Matt Brandt [:mbrandt]]

Spun off from https://bugzilla.mozilla.org/show_bug.cgi?id=654143#c24

When no user marks have been flagged for removal, the moderation page 500's.

http://screencast.com/t/XJfDuh2ddf

Env: Firefox 4.0.1, OSX

Steps to reproduce:
1. Ensure no marks have been flagged for moderation
2. Clear your browsers cache
3. Go to /accounts/login/
4. Login

Expected:
After logging in, the page re-directs to /#/moderate/

Actual:
A 500 ISE is returned:
[10:02:28.131] "[Thu May 05 2011 10:02:28 GMT-0700 (PDT)]" "runRoute" "get
#/moderate"
[10:02:28.170] GET
https://statse.webtrendslive.com/dcs9dibiiuz5bdj1562ysppji_6g1s/dcs.gif?&dcsdat=1304614948109&dcssip=markup.allizom.org&dcsuri=/en-US/&dcsref=https://markup.allizom.org/accounts/login/&WT.tz=-7&WT.bh=10&WT.ul=en-US&WT.cd=24&WT.sr=1920x1200&WT.jo=Yes&WT.ti=Mozilla%20Firefox%20Mark%20Up&WT.js=Yes&WT.jv=1.8&WT.ct=unknown&WT.bs=891x679&WT.fv=10.1&WT.slv=Not%20enabled&WT.tv=9.3.0&WT.dl=0&WT.ssl=1&WT.es=markup.allizom.org/en-US/&WT.vt_f_a=2&WT.vt_f=2
[HTTP/1.1 200 OK 166ms]
[10:02:28.216] GET https://markup.allizom.org/en-US/moderate_sammy.html
[HTTP/1.1 200 OK 76ms]
[10:02:28.665] GET https://markup.allizom.org/media/assets/images/playback.gif
[HTTP/1.1 200 OK 10ms]
[10:02:28.671] GET
https://markup.allizom.org/media/assets/js/vendor/country_codes.json [HTTP/1.1
200 OK 11ms]
[10:02:28.706] GET
https://markup.allizom.org/requests/marks_by_flagged?offset=0&max=20 [HTTP/1.1
500 INTERNAL SERVER ERROR 23ms]
[10:02:28.773] GET
https://markup.allizom.org/media/assets/images/light_overlay.png [HTTP/1.1 200
OK 20ms]
[10:02:28.779] GET
https://markup.allizom.org/media/assets/images/loader_light.gif [HTTP/1.1 200
OK 20ms]

Comment 1

[[:brez]]

Reset this to use the orignal 'no marks found' message

Comment 2

[[:brez]]

https://github.com/mozilla/markup/commit/0da7ba8643c8dba43e095203e18eaa8c159a0ad0

Comment 3

[Matt Brandt [:mbrandt]]

I'm not sure if the patch has landed but I don't see the behavior in comment 1.

Comment 4

[Laura Mesa [:lmesa] [:lvmesa]]

It no longer goes to 500 page--now, send a "oops, there was an error message".

This is verified.

Comment 5

[Matt Brandt [:mbrandt]]

Laura, I suspect what you're seeing is due to bug 655805.