655162 - A missing updates property in an update.rdf should be counted as no available updates not as a failure to check for updates

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

See bug 655143

We changed this in Firefox 4. It is mostly harmless but this was never considered an error case before so I guess there is no good reason why it should be now.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This changes a missing updates property to mean no update but keeps an updates property that is something other than an RDF container as an error and tests both cases.

Comment 2

[Asa Dotzler [:asa]]

not going to track this but we can talk about an approval when the patch is finished, reviewed and landed on m-c.

Comment 3

[Dave Townsend [:mossop]]

Landed yesterday: http://hg.mozilla.org/mozilla-central/rev/c6c669e643b5

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 530459 [details] [diff] [review]
patch rev 1

I'd like to land this before the last beta merge to make sure we take care of the update issue we discovered in bug 655143 one way or another (and for non-AMO add-ons as well). This is real low risk.

Comment 5

[Dave Townsend [:mossop]]

Now that AMO fixed the bug their side, users will only see the error from bug 655143 if they have add-ons installed from somewhere other than AMO and that update site is returning the same empty RDF that AMO used to. This is probably a small class of user but this patch should also be very safe.

Comment 6

[Asa Dotzler [:asa]]

I'm in favor of taking this fix for 5 if we are indeed intending to "push harder" on users to upgrade to our latest release. One less speedbump in the upgrade process, even for a small-ish group of users, would be really nice.

Comment 7

[Dave Townsend [:mossop]]

Landed:
http://hg.mozilla.org/releases/mozilla-aurora/rev/2d075d565dc7
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0b42a6218f

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110529 Firefox/7.0a1

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a2) Gecko/20110529 Firefox/6.0a2

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0