Closed Bug 655198 Opened 14 years ago Closed 14 years ago

The 'all' value for -moz-hyphens is not actually implemented, so should not be parsed in CSS

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Tracking Status
firefox6 - ---

People

(Reporter: jruderman, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 253317 part 1 adds "-moz-hyphen: none/all/manual/auto". Part 6 adds reftests that cover all the cases except for "all".
This is because we don't yet implement the "all" value. (Note that http://www.w3.org/TR/2011/WD-css3-text-20110412/ says that the "all" value is at risk of being dropped from the spec.)
I didn't realize we parse "all". We should refuse to parse it given we don't implement it. I'm not sure what "all" is for and I don't see any reason to implement it.
I'm fine with dropping "all"; I'll put up a patch to do so.
Morphing this bug to refer to removing 'all' instead of adding tests for it.
Summary: No reftests for "-moz-hyphens: all" → The 'all' value for -moz-hyphens is not actually implemented, so not be parsed in CSS
Removing 'all' from -moz-hyphens, as we don't actually implement it (and have no plans to do so).
Assignee: nobody → jfkthame
Attachment #530825 - Flags: review?(dbaron)
Comment on attachment 530825 [details] [diff] [review] patch, don't parse 'all' as a value for '-moz-hyphens' r=dbaron
Attachment #530825 - Flags: review?(dbaron) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
[in triage meeting] No longer need to track this since it's fixed; we just needed to make sure we got this in before we shipped -moz-hyphens.
Summary: The 'all' value for -moz-hyphens is not actually implemented, so not be parsed in CSS → The 'all' value for -moz-hyphens is not actually implemented, so should not be parsed in CSS
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: