655198 - The 'all' value for -moz-hyphens is not actually implemented, so should not be parsed in CSS

Status: RESOLVED FIXED

Description

[Jesse Ruderman]

Bug 253317 part 1 adds "-moz-hyphen: none/all/manual/auto". Part 6 adds reftests that cover all the cases except for "all".

Comment 1

[Jonathan Kew (:jfkthame)]

This is because we don't yet implement the "all" value.

(Note that http://www.w3.org/TR/2011/WD-css3-text-20110412/ says that the "all" value is at risk of being dropped from the spec.)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I didn't realize we parse "all". We should refuse to parse it given we don't implement it.

I'm not sure what "all" is for and I don't see any reason to implement it.

Comment 3

[Jonathan Kew (:jfkthame)]

I'm fine with dropping "all"; I'll put up a patch to do so.

Comment 4

[Jonathan Kew (:jfkthame)]

Morphing this bug to refer to removing 'all' instead of adding tests for it.

Comment 5

[Jonathan Kew (:jfkthame)]

Created attachment 530825 [details] [diff] [review]
patch, don't parse 'all' as a value for '-moz-hyphens'

Removing 'all' from -moz-hyphens, as we don't actually implement it (and have no plans to do so).

Comment 6

[David Baron :dbaron: ⌚️UTC-7]

Comment on attachment 530825 [details] [diff] [review]
patch, don't parse 'all' as a value for '-moz-hyphens'

r=dbaron

Comment 7

[Jonathan Kew (:jfkthame)]

http://hg.mozilla.org/mozilla-central/rev/dac74f0a1882

Comment 8

[David Baron :dbaron: ⌚️UTC-7]

[in triage meeting] No longer need to track this since it's fixed; we just needed to make sure we got this in before we shipped -moz-hyphens.