The 'all' value for -moz-hyphens is not actually implemented, so should not be parsed in CSS

RESOLVED FIXED

Status

()

Core
Layout: Text
--
minor
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: jfkthame)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox6-)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Bug 253317 part 1 adds "-moz-hyphen: none/all/manual/auto". Part 6 adds reftests that cover all the cases except for "all".
(Assignee)

Comment 1

6 years ago
This is because we don't yet implement the "all" value.

(Note that http://www.w3.org/TR/2011/WD-css3-text-20110412/ says that the "all" value is at risk of being dropped from the spec.)
I didn't realize we parse "all". We should refuse to parse it given we don't implement it.

I'm not sure what "all" is for and I don't see any reason to implement it.
(Assignee)

Comment 3

6 years ago
I'm fine with dropping "all"; I'll put up a patch to do so.
(Assignee)

Comment 4

6 years ago
Morphing this bug to refer to removing 'all' instead of adding tests for it.
Summary: No reftests for "-moz-hyphens: all" → The 'all' value for -moz-hyphens is not actually implemented, so not be parsed in CSS
(Assignee)

Comment 5

6 years ago
Created attachment 530825 [details] [diff] [review]
patch, don't parse 'all' as a value for '-moz-hyphens'

Removing 'all' from -moz-hyphens, as we don't actually implement it (and have no plans to do so).
Assignee: nobody → jfkthame
Attachment #530825 - Flags: review?(dbaron)
Comment on attachment 530825 [details] [diff] [review]
patch, don't parse 'all' as a value for '-moz-hyphens'

r=dbaron
Attachment #530825 - Flags: review?(dbaron) → review+
tracking-firefox6: --- → ?
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/mozilla-central/rev/dac74f0a1882
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
[in triage meeting] No longer need to track this since it's fixed; we just needed to make sure we got this in before we shipped -moz-hyphens.
tracking-firefox6: ? → -
Blocks: 656750
(Reporter)

Updated

5 years ago
Summary: The 'all' value for -moz-hyphens is not actually implemented, so not be parsed in CSS → The 'all' value for -moz-hyphens is not actually implemented, so should not be parsed in CSS
You need to log in before you can comment on or make changes to this bug.