Closed Bug 655240 Opened 9 years ago Closed 8 years ago

Intermittent failure in content/html/document/test/test_bug448564.html | Test timed out.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

s: talos-r3-fed64-046
62119 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug448564.html | Test timed out.

http://tinderbox.mozilla.org/showlog.cgi?log=Cedar/1304678289.1304679496.12575.gz
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #540425 - Flags: review?(jonas)
Attachment #540425 - Flags: feedback?(ehsan)
Whiteboard: [orange] → [orange][needs review]
Attached patch Patch v1Splinter Review
Attachment #540425 - Attachment is obsolete: true
Attachment #540425 - Flags: review?(jonas)
Attachment #540425 - Flags: feedback?(ehsan)
Attachment #540427 - Flags: review?(jonas)
Attachment #540427 - Flags: feedback?(ehsan)
Comment on attachment 540427 [details] [diff] [review]
Patch v1

I'm not really sure how this patch is going to fix the orange.  Also, Doesn't this potentially change the semantics of the test?
(In reply to comment #14)
> I'm not really sure how this patch is going to fix the orange.

I'm not sure either but I think it makes the test much saner and simple to understand. It might fix the orange in the way. Otherwise, it will be easier to track the issue.

> Also, Doesn't this potentially change the semantics of the test?

I don't think so. The idea of this test is to submit the three forms and make sure everything is okay. I'm still using the SJS and the same HTML code in the frames. The only difference is I'm checking the frames when all of them are done, not each one individually. I don't think that change can change the semantic of the test.
Attachment #540427 - Flags: feedback?(ehsan) → feedback+
Comment on attachment 540427 [details] [diff] [review]
Patch v1

Review of attachment 540427 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #540427 - Flags: review?(jonas) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/e00de9b8df15

Marking it as fixed and will reopen if a failure happens again.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [orange][needs review] → [orange]
Target Milestone: --- → mozilla7
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.