655241 - Crash with two or more folderLocationPopups like in message filters with Move To and Copy To [@ nsXULTreeBuilder::RemoveMatchesFor(nsTreeRows::Subtree&) ]

Status: RESOLVED DUPLICATE of bug 397744

(Core :: XUL, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10

Thunderbird crashes if you use the Move To and Copy To commands in the message filters and add both actions before focusing the folder picker of the first one.

Steps to reproduce:
1. Create a new profile with a fake account.
2. Open Tools > Message filters.
3. Click New for a new rule.
4. Click the '+' button behind the default filter action 'Move To'. A 'Copy To' action should be added.
5. Now click into one folder picker and select a folder (I used Outbox), then click into the other folder picker.

Actual result: [@ nsXULTreeBuilder::RemoveMatchesFor(nsTreeRows::Subtree&) ]
https://crash-stats.mozilla.com/report/index/bp-d2e1ed31-2db7-415e-9c71-1849d2110506

The problem seems to be gone if you expand the Move To folder picker before adding the second one (even after Thunderbird restart).

In Mozilla/5.0 (Windows NT 5.1; rv:5.0a2) Gecko/20110506 Thunderbird/3.3a4pre clicking first on Copy To folder picker and then Move To shows only the accounts, not theirs folder for the first click, but no crash occurs.

Comment 1

[Wayne Mery (:wsmwk)]

(In reply to comment #0)
> In Mozilla/5.0 (Windows NT 5.1; rv:5.0a2) Gecko/20110506
> Thunderbird/3.3a4pre clicking first on Copy To folder picker and then Move
> To shows only the accounts, not theirs folder for the first click, 

I don't understand this part.

I also don't crash in version 3.3. And if you don't, perhaps we should mod this bug to be your non-crash issue.  (note also, firefox 3.6.x has crashes for nsXULTreeBuilder::RemoveMatchesFor(nsTreeRows::Subtree& but there are none for FF 4.)


bp-d2e1ed31-2db7-415e-9c71-1849d2110506
EXCEPTION_ACCESS_VIOLATION_READ
0x4
0	thunderbird.exe	nsXULTreeBuilder::RemoveMatchesFor	content/xul/templates/src/nsXULTreeBuilder.cpp:1733
1	thunderbird.exe	nsXULTreeBuilder::CloseContainer	content/xul/templates/src/nsXULTreeBuilder.cpp:1710
2	thunderbird.exe	nsXULTreeBuilder::ToggleOpenState	content/xul/templates/src/nsXULTreeBuilder.cpp:870
3	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
4	thunderbird.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2722
5	thunderbird.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1740
6	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1360
7	js3250.dll	js_Interpret	js/src/jsops.cpp:2240
8	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1368
9	js3250.dll	js_InternalInvoke	js/src/jsinterp.cpp:1423
10	js3250.dll	JS_CallFunction	js/src/jsapi.cpp:5099
11	thunderbird.exe	nsJSContext::CallEventHandler	dom/base/nsJSEnvironment.cpp:2197
12	thunderbird.exe	nsJSEventListener::HandleEvent	dom/src/events/nsJSEventListener.cpp:269
13	thunderbird.exe	nsXBLPrototypeHandler::ExecuteHandler	content/xbl/src/nsXBLPrototypeHandler.cpp:343
14	thunderbird.exe	nsXBLEventHandler::HandleEvent	content/xbl/src/nsXBLEventHandler.cpp:88
15	thunderbird.exe	nsEventListenerManager::HandleEventSubType	content/events/src/nsEventListenerManager.cpp:1041
16	thunderbird.exe	nsEventListenerManager::HandleEvent	content/events/src/nsEventListenerManager.cpp:1147

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

So a dupe of bug 397744?

I'm attaching a screenshot for the folder list only showing the accounts.

As extension developer, I am planning to release an extension which uses two folder popups in a xul dialog and would have to tell users to do the message filter list 'dance' to avoid crashes (I haven't tried creating hidden windows and performing the fixing steps in it).

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: only accounts in folder dropdown

Comment 4

[Wayne Mery (:wsmwk)]

probably duplicate.

no thunderbird crashes in 3 weeks newer than version 3.1.7