655283 - Remove the plugin aliases

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Tarek Ziadé (:tarek)]

The auth and storage registry have preloads backends that can be used with aliases (ldap, sql etc)

This turns out to be a bad idea because we preload them and mask issues.

I am going to remove this feature so backends will have to be configured via the fully qualified name.

We should change this configuration in stage and prod now, since the fully qualified names are already working.

Comment 1

[Tarek Ziadé (:tarek)]

Attachment: Removes aliases in server-core

This patch is for server-core.

Upcoming patches for server-sreg, server-reg, server-full

Plugin.get() is now looking for the fully qualified name

Comment 2

[Toby Elliott [:telliott]]

Comment on attachment 539542 [details] [diff] [review]
Removes aliases in server-core

looks good.

Comment 3

[Toby Elliott [:telliott]]

Initial patch in http://hg.mozilla.org/services/server-core/rev/7a8b43a11714

Comment 4

[Toby Elliott [:telliott]]

Attachment: Pulls config management into the controller/app classes

Comment 5

[Tarek Ziadé (:tarek)]

Comment on attachment 541042 [details] [diff] [review]
Pulls config management into the controller/app classes

looks good. a few nitpicks:

1/ params = config

we could use config everywhere, I don't think using a new variable add value here

2/ cls_param 

I think the name is a bit vague, but I can't come up with a good one, maybe backend_variable ?

Comment 6

[Toby Elliott [:telliott]]

1. done
2. I used cls_name_field

pushed in http://hg.mozilla.org/services/server-core/rev/16ea2e83a6d5 and http://hg.mozilla.org/services/server-core/rev/20854788b894

Also had to update a couple places in server-core (notably the test support module and the auth __init__ get_auth method) to make sure they filtered their config file.