Last Comment Bug 655517 - Remove nsIDOMDocumentEvent
: Remove nsIDOMDocumentEvent
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla6
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 1183845
  Show dependency treegraph
 
Reported: 2011-05-07 12:40 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2015-07-14 14:11 PDT (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (50.29 KB, patch)
2011-05-07 12:40 PDT, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
ehsan: feedback+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-05-07 12:40:43 PDT
Created attachment 530872 [details] [diff] [review]
Patch v1
Comment 1 Olli Pettay [:smaug] 2011-05-07 14:37:07 PDT
Comment on attachment 530872 [details] [diff] [review]
Patch v1


> #define DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES                                    \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSDocument)                                 \
>-    DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentEvent)                              \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentStyle)                              \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSDocumentStyle)                            \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentXBL)                                \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSEventTarget)                              \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMEventTarget)                                \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOM3Node)                                      \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMXPathEvaluator)                             \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNodeSelector)

Strange that DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES doesn't have nsIDOMDocument.
Could you either fix that here, of file a followup bug.


>@@ -128,9 +129,12 @@ interface nsIDOMDocument : nsIDOMNode
>                                         in nsIDOMNodeFilter filter,
>                                         in boolean entityReferenceExpansion)
>                                         raises(DOMException);
>   nsIDOMTreeWalker   createTreeWalker(in nsIDOMNode root,
>                                       in unsigned long whatToShow,
>                                       in nsIDOMNodeFilter filter,
>                                       in boolean entityReferenceExpansion)
>                                         raises(DOMException);
>+
>+  nsIDOMEvent               createEvent(in DOMString eventType)
>+                                               raises(DOMException);
Although the change may be binary compatible, I'd like to see iid updated.
Update also all the interfaces which inherit nsIDOMDocument.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-05-08 09:02:42 PDT
(In reply to comment #1)
> Comment on attachment 530872 [details] [diff] [review] [review]
> Patch v1
> 
> Strange that DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES doesn't have nsIDOMDocument.
> Could you either fix that here, of file a followup bug.

Filed bug 655598.

> >@@ -128,9 +129,12 @@ interface nsIDOMDocument : nsIDOMNode
> >                                         in nsIDOMNodeFilter filter,
> >                                         in boolean entityReferenceExpansion)
> >                                         raises(DOMException);
> >   nsIDOMTreeWalker   createTreeWalker(in nsIDOMNode root,
> >                                       in unsigned long whatToShow,
> >                                       in nsIDOMNodeFilter filter,
> >                                       in boolean entityReferenceExpansion)
> >                                         raises(DOMException);
> >+
> >+  nsIDOMEvent               createEvent(in DOMString eventType)
> >+                                               raises(DOMException);
> Although the change may be binary compatible, I'd like to see iid updated.
> Update also all the interfaces which inherit nsIDOMDocument.

Will do.
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2011-05-23 12:32:12 PDT
http://hg.mozilla.org/mozilla-central/rev/8bd4182413e0

Note You need to log in before you can comment on or make changes to this bug.