655517 - Remove nsIDOMDocumentEvent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 530872 [details] [diff] [review]
Patch v1


> #define DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES                                    \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSDocument)                                 \
>-    DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentEvent)                              \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentStyle)                              \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSDocumentStyle)                            \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentXBL)                                \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSEventTarget)                              \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMEventTarget)                                \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOM3Node)                                      \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMXPathEvaluator)                             \
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNodeSelector)

Strange that DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES doesn't have nsIDOMDocument.
Could you either fix that here, of file a followup bug.


>@@ -128,9 +129,12 @@ interface nsIDOMDocument : nsIDOMNode
>                                         in nsIDOMNodeFilter filter,
>                                         in boolean entityReferenceExpansion)
>                                         raises(DOMException);
>   nsIDOMTreeWalker   createTreeWalker(in nsIDOMNode root,
>                                       in unsigned long whatToShow,
>                                       in nsIDOMNodeFilter filter,
>                                       in boolean entityReferenceExpansion)
>                                         raises(DOMException);
>+
>+  nsIDOMEvent               createEvent(in DOMString eventType)
>+                                               raises(DOMException);
Although the change may be binary compatible, I'd like to see iid updated.
Update also all the interfaces which inherit nsIDOMDocument.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to comment #1)
> Comment on attachment 530872 [details] [diff] [review] [review]
> Patch v1
> 
> Strange that DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES doesn't have nsIDOMDocument.
> Could you either fix that here, of file a followup bug.

Filed bug 655598.

> >@@ -128,9 +129,12 @@ interface nsIDOMDocument : nsIDOMNode
> >                                         in nsIDOMNodeFilter filter,
> >                                         in boolean entityReferenceExpansion)
> >                                         raises(DOMException);
> >   nsIDOMTreeWalker   createTreeWalker(in nsIDOMNode root,
> >                                       in unsigned long whatToShow,
> >                                       in nsIDOMNodeFilter filter,
> >                                       in boolean entityReferenceExpansion)
> >                                         raises(DOMException);
> >+
> >+  nsIDOMEvent               createEvent(in DOMString eventType)
> >+                                               raises(DOMException);
> Although the change may be binary compatible, I'd like to see iid updated.
> Update also all the interfaces which inherit nsIDOMDocument.

Will do.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/8bd4182413e0