Closed Bug 655588 Opened 9 years ago Closed 9 years ago

Desaturating filter produces more realistic grey scale than colour averaging

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla6

People

(Reporter: neil, Assigned: neil)

References

Details

(Whiteboard: [bugday-20110513])

Attachments

(1 file)

The Add-Ons manager uses a colour averaging filter to grey scale disable icons. However the most common strategy (as used by my paint package and also apparently GIMP, according to Wikipedia) is to match the luminance of the grey scale image to that of the colour image. This is most readily achieved through the use of the saturating SVG filter to completely desaturate the image.
Attached patch Proposed patchSplinter Review
Also with dos2unix line ending conversion...
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #530920 - Flags: review?(bmcbride)
Comment on attachment 530920 [details] [diff] [review]
Proposed patch

Makes sense :)
Attachment #530920 - Flags: review?(bmcbride) → review+
Pushed changeset 388cde12c89d to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Looks pretty nice with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110512 Firefox/6.0a1.
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla6
Whiteboard: [bugday-20110513]
Oh, and I don't think there is a need for tests.
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.