Code cleanup in nsGNOMERegistry.cpp

VERIFIED FIXED in mozilla6

Status

Core Graveyard
File Handling
--
minor
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

Trunk
mozilla6
All
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 530967 [details] [diff] [review]
A patch

The code in nsGNOMERegistry.cpp is little bit inefficient.

1) do_GetService for nsIGnomeVFSService is called even if it is not needed.
2) Redundant if (giovfs)...else statement in nsGNOMERegistry::GetFromType.
(Assignee)

Updated

6 years ago
Attachment #530967 - Flags: review?(karlt)
Comment on attachment 530967 [details] [diff] [review]
A patch

Nice and tidy, thanks.

I assume this bug doesn't need to be security-sensitive?
Attachment #530967 - Flags: review?(karlt) → review+
Assignee: nobody → hiikezoe
Group: core-security
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Pushed:
http://hg.mozilla.org/mozilla-central/rev/820891761ab4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6

Comment 3

6 years ago
Setting resolution to Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20100101 Firefox/6.0
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.