Closed
Bug 655633
Opened 13 years ago
Closed 13 years ago
Code cleanup in nsGNOMERegistry.cpp
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla6
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(1 file)
|
5.18 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
The code in nsGNOMERegistry.cpp is little bit inefficient. 1) do_GetService for nsIGnomeVFSService is called even if it is not needed. 2) Redundant if (giovfs)...else statement in nsGNOMERegistry::GetFromType.
|
Assignee | |
Updated•13 years ago
|
Attachment #530967 -
Flags: review?(karlt)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 530967 [details] [diff] [review] A patch Nice and tidy, thanks. I assume this bug doesn't need to be security-sensitive?
Attachment #530967 -
Flags: review?(karlt) → review+
|
||
Updated•13 years ago
|
Assignee: nobody → hiikezoe
Group: core-security
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
|
|
||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Version: unspecified → Trunk
|
|
||
Comment 2•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/820891761ab4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
Setting resolution to Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20100101 Firefox/6.0
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•