Closed Bug 655633 Opened 9 years ago Closed 9 years ago

Code cleanup in nsGNOMERegistry.cpp

Categories

(Core Graveyard :: File Handling, defect, minor)

All
Linux
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
mozilla6

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file)

Attached patch A patchSplinter Review
The code in nsGNOMERegistry.cpp is little bit inefficient.

1) do_GetService for nsIGnomeVFSService is called even if it is not needed.
2) Redundant if (giovfs)...else statement in nsGNOMERegistry::GetFromType.
Attachment #530967 - Flags: review?(karlt)
Comment on attachment 530967 [details] [diff] [review]
A patch

Nice and tidy, thanks.

I assume this bug doesn't need to be security-sensitive?
Attachment #530967 - Flags: review?(karlt) → review+
Assignee: nobody → hiikezoe
Group: core-security
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Pushed:
http://hg.mozilla.org/mozilla-central/rev/820891761ab4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
Setting resolution to Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20100101 Firefox/6.0
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.