655676 - Preproduction slaves should remove old build directories more aggressively

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Rail Aliiev [:rail]]

By default tools/buildfarm/maintenance/purge_builds.py removes directories older than 14 days. It would be better to have this parameter configurable and set it to 3-4 days for preproduction.

Comment 1

[Rail Aliiev [:rail]]

Attachment: use config for purge_builds.py

I think the easiest way would be using a config file for setting max_age. Adding another parameter to MozillaBuildFactory would be a mess.

We can use different files for staging/production or remove the configs from production machines and use default values.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 531322 [details] [diff] [review]
use config for purge_builds.py

Seems like a good approach for a tool like this.

Comment 3

[Rail Aliiev [:rail]]

Attachment: puppet-manifests

Comment 4

[Rail Aliiev [:rail]]

Attachment: OPSI packages

To be tested.

Comment 5

[Rail Aliiev [:rail]]

Attachment: puppet-manifests

Comment 6

[Rail Aliiev [:rail]]

Attachment: OPSI packages

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 531582 [details] [diff] [review]
puppet-manifests

I think that keeping the config files in hg is better than keeping them under /N/{staging,production}, especially if the files are small and platform independent.

Comment 8

[Rail Aliiev [:rail]]

All patches passed staging tests.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 531582 [details] [diff] [review]
puppet-manifests

Looks good.  Eventually, this will need to distinguish between a puppet-staging slave and a dev/pp slave, but for now this is close enough.

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 531582 [details] [diff] [review]
puppet-manifests

http://hg.mozilla.org/build/puppet-manifests/rev/50cb08591554

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 531594 [details] [diff] [review]
OPSI packages

http://hg.mozilla.org/build/opsi-package-sources/rev/0e1858f4ad42

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 531322 [details] [diff] [review]
use config for purge_builds.py

http://hg.mozilla.org/build/tools/rev/a67746f8bcbe

Comment 13

[Rail Aliiev [:rail]]

(In reply to comment #12)
> Comment on attachment 531322 [details] [diff] [review] [review]
> use config for purge_builds.py
> 
> http://hg.mozilla.org/build/tools/rev/a67746f8bcbe

Oh, forgot to mention that I've added ValueError to the list of exceptions to catch config.getint exceptions. r=dustin on IRC.

Comment 14

[Rail Aliiev [:rail]]

Bustage fix: http://hg.mozilla.org/build/tools/rev/a796ec25efe3