Closed Bug 655676 Opened 14 years ago Closed 14 years ago

Preproduction slaves should remove old build directories more aggressively

Categories

(Release Engineering :: General, defect, P3)

Product:
Release Engineering
Component:
General
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

Details

(Whiteboard: [preproduction][buildslaves])

Attachments

(3 files, 2 obsolete files)

use config for purge_builds.py
1.08 KB, patch
dustin
: review+
bhearsum
: feedback+
rail
: checked-in+
Details | Diff | Splinter Review
puppet-manifests
2.15 KB, patch
dustin
: review+
dustin
: feedback+
rail
: checked-in+
Details | Diff | Splinter Review
OPSI packages
5.01 KB, patch
dustin
: review+
dustin
: feedback+
rail
: checked-in+
Details | Diff | Splinter Review
By default tools/buildfarm/maintenance/purge_builds.py removes directories older than 14 days. It would be better to have this parameter configurable and set it to 3-4 days for preproduction.
I think the easiest way would be using a config file for setting max_age. Adding another parameter to MozillaBuildFactory would be a mess. We can use different files for staging/production or remove the configs from production machines and use default values.
Attachment #531322 - Flags: feedback?(bhearsum)
Comment on attachment 531322 [details] [diff] [review] use config for purge_builds.py Seems like a good approach for a tool like this.
Attachment #531322 - Flags: feedback?(bhearsum) → feedback+
Attached patch puppet-manifests (obsolete) — — Splinter Review
Attached patch OPSI packages (obsolete) — — Splinter Review
To be tested.
Attached patch puppet-manifests — — Splinter Review
Attachment #531327 - Attachment is obsolete: true
Attached patch OPSI packages — — Splinter Review
Attachment #531329 - Attachment is obsolete: true
Comment on attachment 531582 [details] [diff] [review] puppet-manifests I think that keeping the config files in hg is better than keeping them under /N/{staging,production}, especially if the files are small and platform independent.
All patches passed staging tests.
Attachment #531322 - Flags: review?(catlee)
Attachment #531582 - Flags: review?(catlee)
Attachment #531594 - Flags: review?(catlee)
Comment on attachment 531582 [details] [diff] [review] puppet-manifests Looks good. Eventually, this will need to distinguish between a puppet-staging slave and a dev/pp slave, but for now this is close enough.
Attachment #531582 - Flags: feedback+
Attachment #531582 - Flags: review?(catlee) → review+
Attachment #531594 - Flags: review?(catlee) → review+
Attachment #531322 - Flags: review?(catlee) → review+
Comment on attachment 531322 [details] [diff] [review] use config for purge_builds.py http://hg.mozilla.org/build/tools/rev/a67746f8bcbe
Attachment #531322 - Flags: checked-in+
(In reply to comment #12) > Comment on attachment 531322 [details] [diff] [review] [review] > use config for purge_builds.py > > http://hg.mozilla.org/build/tools/rev/a67746f8bcbe Oh, forgot to mention that I've added ValueError to the list of exceptions to catch config.getint exceptions. r=dustin on IRC.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: