Preproduction slaves should remove old build directories more aggressively

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preproduction][buildslaves])

Attachments

(3 attachments, 2 obsolete attachments)

By default tools/buildfarm/maintenance/purge_builds.py removes directories older than 14 days. It would be better to have this parameter configurable and set it to 3-4 days for preproduction.
Created attachment 531322 [details] [diff] [review]
use config for purge_builds.py

I think the easiest way would be using a config file for setting max_age. Adding another parameter to MozillaBuildFactory would be a mess.

We can use different files for staging/production or remove the configs from production machines and use default values.
Attachment #531322 - Flags: feedback?(bhearsum)
Comment on attachment 531322 [details] [diff] [review]
use config for purge_builds.py

Seems like a good approach for a tool like this.
Attachment #531322 - Flags: feedback?(bhearsum) → feedback+
Created attachment 531329 [details] [diff] [review]
OPSI packages

To be tested.
Created attachment 531582 [details] [diff] [review]
puppet-manifests
Attachment #531327 - Attachment is obsolete: true
Created attachment 531594 [details] [diff] [review]
OPSI packages
Attachment #531329 - Attachment is obsolete: true
Comment on attachment 531582 [details] [diff] [review]
puppet-manifests

I think that keeping the config files in hg is better than keeping them under /N/{staging,production}, especially if the files are small and platform independent.
All patches passed staging tests.
Attachment #531322 - Flags: review?(catlee)
Attachment #531582 - Flags: review?(catlee)
Attachment #531594 - Flags: review?(catlee)
Comment on attachment 531582 [details] [diff] [review]
puppet-manifests

Looks good.  Eventually, this will need to distinguish between a puppet-staging slave and a dev/pp slave, but for now this is close enough.
Attachment #531582 - Flags: feedback+
Attachment #531582 - Flags: review?(catlee) → review+
Attachment #531594 - Flags: review?(catlee) → review+
Attachment #531322 - Flags: review?(catlee) → review+
(In reply to comment #12)
> Comment on attachment 531322 [details] [diff] [review] [review]
> use config for purge_builds.py
> 
> http://hg.mozilla.org/build/tools/rev/a67746f8bcbe

Oh, forgot to mention that I've added ValueError to the list of exceptions to catch config.getint exceptions. r=dustin on IRC.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.