655688 - nsHTMLSelectElement::SaveState (select state saving/restoration) should only save the state if the selected option set changed

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Paul Biggar]

I believe there is a bug in saving a forms contents after refreshing. I think it would be fixed by not saving fields/drop-downs which I don't change.


I've had a problem for a few months now where submitting changes to Bugzilla would change things I hadn't touched. For example, I might somehow set the platform to 'Linux', even though I wasn't on Linux and even though I didn't explicitly make that change.


Here's what I think happens:

1) I open a bug someone filed, and read it (platform=Linux)
2) Some time later I refresh that page, bringing in changes that others have made (setting platform=All)
3) I add a comment, then submit (platform=Linux again - Whoops!)


My guess is that I can workaround this by doing a CMD+SHIFT+R, and that the proper fix would be to only save fields that I actually change myself.

Comment 1

[Boris Zbarsky [:bzbarsky]]

> My guess is that I can workaround this by doing a CMD+SHIFT+R

Yes.

> that the proper fix would be to only save fields that I actually change myself

We do that in general, but apparently not for <select>.  See nsHTMLSelectElement::SaveState, which just always saves the selected option set (but only saves disabled state when mDisabledChanged, say).

I'm 99% sure this is a duplicate...

Comment 2

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.