Closed Bug 655731 Opened 9 years ago Closed 9 years ago

If panned prior to discoverability demo start, a grey area is visible behind the visible sidebar

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 6

People

(Reporter: aaronmt, Assigned: mbrubeck)

References

Details

(Keywords: polish)

Attachments

(2 files)

Attached image Screenshot
Device: Nexus One

Mozilla/5.0 (Android; Linux armv7l; rv:6.0a1) Gecko/20110509; Firefox/6.0a1 Fennec/6.0a1

If a user pans to expose either left or right sidebars prior to the start of the demo animation on about:firstrun, there will be an exposed grey area to either 
the left or right of the associated sidebar.

See attached screenshot.

IRC: mbrubeck mentions -- 'we need to reset the scroll position before starting the demo'
Summary: If panned prior to demo start grey area is visible behind sidebars → If panned prior to discoverability demo start, a grey area is visible behind the visible sidebar
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Keywords: polish
OS: Android → All
Hardware: ARM → All
Attached patch patchSplinter Review
This patch just skips the demo if a sidebar is already open when about:firstrun loads.

(As mentioned above, we could also fix this by resetting the scroll position before running the demo.)
Attachment #531063 - Flags: review?(wjohnston)
Comment on attachment 531063 [details] [diff] [review]
patch

I'm fine with this. I think it will be fairly odd that users decide to intentionally visit about:firstrun anyway.
Attachment #531063 - Flags: review?(wjohnston) → review+
http://hg.mozilla.org/mozilla-central/rev/508c54f63824
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110511 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.