655738 - [stage] character count on feedback forms is gone.

Status: VERIFIED FIXED

(Input :: General, defect, P1)

Description

[Matt Brandt [:mbrandt]]

Attachment: Character count

The character count no longer shows up on the feedback forms #happy, #sad, and #ideas.

Steps to reproduce:
1. go to input.stage.mozilla.com/feedback/
2. browse any of the forms (#happy, #sad, or #ideas)
3. type some text into a form

Suggested:
- a character count visibly decrements

Actual:
- there is no character count. This appears to regressed from what is on prod.

Comment 1

[Matt Brandt [:mbrandt]]

Just curious if this bug has been considered yet. davehunt was the first to point this out and caught it with our automation. Is this a real bug or a feature that we're dropping?

Comment 2

[Aakash Desai [:aakashd]]

Ah, sorry; I lost track of this. 

Dave, will someone have enough time to get to this in the 4.0 timeline?

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Not this late in the game.

This isn't a regression - the mocks were implemented as given.  We can add it for 4.1 though, if chowse wants to update the mocks that's fine, or we can slap it on.

Comment 4

[tofumatt [:tofumatt]]

Added a remaining character count; merged into master here: https://github.com/fwenzel/reporter/commit/cff967f4799c8d5c22a2ebd69b7d73babdaf9ade

Tested on both desktop and mobile submission forms (only desktop has the count). Ready for some QA.

Comment 5

[Aakash Desai [:aakashd]]

\o/

Comment 6

[tofumatt [:tofumatt]]

Moving this to 4.0. If QA likes it in time it could probably go in 3.5; it's a pretty trivial change.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

A few observations, using the ideas page as an example, which has a 250 character limit:

Previously we indicated when the remaining characters were low (50 characters remaining), and very low (25 characters remaining). We also disabled the submit button when the character limit had been exceeded.

Now we indicate that the remaining characters are limited (20 characters remaining), and when the character limit has been exceeded.

If the change in behaviour is expected then I can update the automated tests, however I would suggest that at minimum the submit button should be disabled when the character count has been exceeded. This can be raised as a separate bug.

Comment 8

[Aakash Desai [:aakashd]]

The change in behavior is mostly right. When the character limit has been exceeded, the submit button should be disabled (i.e. users can't submit feedback greater than 140 characters).

Comment 9

[tofumatt [:tofumatt]]

I'll disable the submit button after the limit has been exceeded; I'll also update the count to indicate "very low" at 25 instead of 20, but I'd say we can drop the 50 one.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The 'very low' was different depending on the character limit. For happy/sad feedback the character limit is 140, and the 'very low' kicked in at 14.

To summarise the previous behaviour:
Ideas: 250 limit, 50 remaining = low, 25 remaining = very low
Happy/feedback: 140 limit, 28 remaining = low, 14 remaining = very low

I'm not concerned over the thresholds, but wanted to clarify that my previous comment was for the ideas form, which had different thresholds to the happy/sad feedback forms.

Comment 11

[tofumatt [:tofumatt]]

Updated the thresholds to be 20% of max lengths and disabled the submit button here:

https://github.com/tofumatt/reporter/commit/2a7e466f9c6a4eceaae5f9e72ee7cf6e3193ff1d

I don't have access to wenzel's reporter. I'll ping Dave Dash to merge this in.

Comment 12

[Matt Brandt [:mbrandt]]

QA verified manually. The character count decrements as expected. Low is demarked by 20% and when the there is an overage (more than 140 in /happy/ and /sad/ or 250 on /ideas/) the submit button is disabled and grays out. The character count also turns red and shows a negative count for the number of characters over.