655838 - Change throttle rules to use ReleaseChannel

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Laura Thomson :laura]

As we discussed in IRC/email last week, we'd like to proceed with the following change to throttling.  Sheila has given the go-ahead, so we should implement ASAP.

- Any release where the ReleaseChannel is "nightly", "aurora" or "beta" should pass through at 100%
- Other existing rules should stand.

Assigning to Lars because he had a specific idea on the best way to implement this.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

Here's my proposal for throttling rules.

throttleConditions.default = [
    ("Comments", lambda x: x, 100), # 100% of crashes with comments
    ("ReleaseChannel", lambda x: x in ("nightly", "aurora", "beta"), 100),
    ("ProductName", 'Firefox', 10), # 10% of Firefox
    ("Version", re.compile(r'\..*?[a-zA-Z]+'), 100), # 100% of all alpha, beta or special    
    ("ProductName", lambda x: x[0] in 'TSC', 100), # 100% of Thunderbird, SeaMonkey & Camino
    (None, True, 0) # reject everything else                                    
]

The trick here is that we want it to be fast.  The ReleaseChannel rule could be a tiny bit faster if we use the same trick that we use of the ProductName rule and only look at the first letter of the ReleaseChannel.  However, in practicality, I don't think it matters much.

I've changed the ProductName Firefox rule to look at the whole string.  I never really liked that first/last letter rule.

Comment 2

[K Lars Lohn [:lars] [:klohn]]

checked into the trunk, .../branches/releases/1.7.7, and .../branches/lars-178dev1 all at the same time.  r3153  

we're ready to deploy

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to comment #2)
> checked into the trunk, .../branches/releases/1.7.7, and
> .../branches/lars-178dev1 all at the same time.  r3153  
> 
> we're ready to deploy

Deployed to production in bug 655915