Port |Bug 417483 - Double separator in context menu when selecting empty text & using iframes|

RESOLVED FIXED in seamonkey2.2

Status

SeaMonkey
UI Design
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.2
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 531144 [details] [diff] [review]
Port Firefox patch v1.0

Copied from bug 303898, see testcase - https://bugzilla.mozilla.org/attachment.cgi?id=264095

A double separator appears in the context menu when an image from a *sub-frame*
is highlighted.

Steps to reproduce:
1. Visit testcase.
2. Highlight image, be careful not to select any text, only the image.
3. Activate the context menu over the highlighted image.

Result:
A double separator in the menu.
Attachment #531144 - Flags: review?(neil)

Comment 1

7 years ago
Comment on attachment 531144 [details] [diff] [review]
Port Firefox patch v1.0

I don't think this is right.

The "quick" fix is to change the test for context-sep-selectall to only show the separator if actual text is selected.

The "better" fix is to reorder the items. I don't think that "This Frame" belongs between "Search ... for ..." and "View Selection Source".
Attachment #531144 - Flags: review?(neil) → review-
(Assignee)

Comment 2

7 years ago
Created attachment 531281 [details] [diff] [review]
Move frame menu instead patch v2.0 [Checked in: Comment 3]

This patch:
* Moves frame menu to just above spell-separator
Attachment #531144 - Attachment is obsolete: true
Attachment #531281 - Flags: review?(neil)

Updated

7 years ago
Attachment #531281 - Flags: review?(neil) → review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 531281 [details] [diff] [review]
Move frame menu instead patch v2.0 [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/5484b8035db5
Attachment #531281 - Attachment description: Move frame menu instead patch v2.0 → Move frame menu instead patch v2.0 [Checked in: Comment 3]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.2a1
(Assignee)

Updated

7 years ago
Blocks: 566214
(Assignee)

Updated

7 years ago
Blocks: 656801
You need to log in before you can comment on or make changes to this bug.