Last Comment Bug 655918 - We can input longer text by IME on <input> which has maxlength and length of the value has been same as maxlength already
: We can input longer text by IME on <input> which has maxlength and length of ...
Status: RESOLVED FIXED
: inputmethod, regression
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan)
:
: Makoto Kato [:m_kato]
Mentors:
data:text/html,<input maxlength="1" v...
Depends on:
Blocks: 597519
  Show dependency treegraph
 
Reported: 2011-05-09 18:10 PDT by Masayuki Nakano [:masayuki] (Mozilla Japan)
Modified: 2011-05-10 21:57 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1.0 (9.97 KB, patch)
2011-05-09 18:10 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan)
ehsan: review+
Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-05-09 18:10:26 PDT
Created attachment 531221 [details] [diff] [review]
Patch v1.0

1. Open the URL (data:text/html,<input maxlength="1" value="a">).
2. Type something with IME.
3. Commit the composition string.

Then, you can see uncommitted string on the <input> but actually, the composition string was committed.

When editor discards all characters at committing the composition string, it doesn't clean up the textnode for composition string. See the patch for the detail.

This is a regression between Fx3.6 and Fx4. The regression range is between 20101007 and 20101008. I'm not sure the actual bug#.
Comment 1 :Ehsan Akhgari 2011-05-10 12:07:14 PDT
Comment on attachment 531221 [details] [diff] [review]
Patch v1.0

Can you please change the comment to say something like:

// If we're exceeding the maxlength when composing IME, we need to clean up
// the composing text, so we shouldn't return early.

r=me with that.
Comment 2 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-05-10 21:57:23 PDT
http://hg.mozilla.org/mozilla-central/rev/64f5f44a8334

Note You need to log in before you can comment on or make changes to this bug.