Last Comment Bug 656050 - Fix jar reordering on linux PGO builds
: Fix jar reordering on linux PGO builds
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All Linux
: -- normal (vote)
: ---
Assigned To: Michael Wu [:mwu]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-10 10:24 PDT by Michael Wu [:mwu]
Modified: 2011-05-17 11:28 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Move jarlog directory (2.78 KB, patch)
2011-05-10 10:24 PDT, Michael Wu [:mwu]
ted: review+
Details | Diff | Splinter Review

Description Michael Wu [:mwu] 2011-05-10 10:24:08 PDT
Created attachment 531368 [details] [diff] [review]
Move jarlog directory

Our jarlogs are clobbered during PGO which prevents us from reordering the omnijar properly. Fixable by moving the jarlogs to a directory that isn't clobbered during make clean.
Comment 1 Ted Mielczarek [:ted.mielczarek] 2011-05-12 09:11:03 PDT
Comment on attachment 531368 [details] [diff] [review]
Move jarlog directory

Review of attachment 531368 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/pgo/profileserver.py
@@ +54,4 @@
>  
>  PORT = 8888
>  PROFILE_DIRECTORY = os.path.abspath(os.path.join(SCRIPT_DIR, "./pgoprofile"))
> +MOZ_JAR_LOG_DIR = os.path.abspath(os.path.join(os.getenv("OBJDIR"), "jarlog"))

Can we just export this in the environment and getenv it instead? Not a deal-breaker either way.
Comment 2 Michael Wu [:mwu] 2011-05-17 11:28:34 PDT
http://hg.mozilla.org/mozilla-central/rev/2797679ecdec

Note You need to log in before you can comment on or make changes to this bug.