The default bug view has changed. See this FAQ.

Fix jar reordering on linux PGO builds

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 531368 [details] [diff] [review]
Move jarlog directory

Our jarlogs are clobbered during PGO which prevents us from reordering the omnijar properly. Fixable by moving the jarlogs to a directory that isn't clobbered during make clean.
Attachment #531368 - Flags: review?(ted.mielczarek)
Comment on attachment 531368 [details] [diff] [review]
Move jarlog directory

Review of attachment 531368 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/pgo/profileserver.py
@@ +54,4 @@
>  
>  PORT = 8888
>  PROFILE_DIRECTORY = os.path.abspath(os.path.join(SCRIPT_DIR, "./pgoprofile"))
> +MOZ_JAR_LOG_DIR = os.path.abspath(os.path.join(os.getenv("OBJDIR"), "jarlog"))

Can we just export this in the environment and getenv it instead? Not a deal-breaker either way.
Attachment #531368 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/2797679ecdec
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.