Closed
Bug 656050
Opened 13 years ago
Closed 13 years ago
Fix jar reordering on linux PGO builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(1 file)
|
2.78 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Our jarlogs are clobbered during PGO which prevents us from reordering the omnijar properly. Fixable by moving the jarlogs to a directory that isn't clobbered during make clean.
Attachment #531368 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 531368 [details] [diff] [review] Move jarlog directory Review of attachment 531368 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/pgo/profileserver.py @@ +54,4 @@ > > PORT = 8888 > PROFILE_DIRECTORY = os.path.abspath(os.path.join(SCRIPT_DIR, "./pgoprofile")) > +MOZ_JAR_LOG_DIR = os.path.abspath(os.path.join(os.getenv("OBJDIR"), "jarlog")) Can we just export this in the environment and getenv it instead? Not a deal-breaker either way.
Attachment #531368 -
Flags: review?(ted.mielczarek) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/2797679ecdec
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•