656085 - Collage page looks broken

Status: VERIFIED FIXED

(Websites :: webifyme.org, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Complete the quiz on webifyme
2. Select the option to add the collage to the gallery and provide whatever relevant information is necessary.
3. Click on 'get my results'

observed behavior:
https://webifyme-dev.allizom.org/collage/79804bb6f36f/ loads and the entire page looks broken

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

[12:04:37.575] GET https://webifyme-dev.allizom.org/static/objects/large/ [HTTP/1.1 403 Forbidden 261ms] could be related to.

Comment 2

[krupa raj[:krupa]]

[12:13:37.658] POST https://webifyme-dev.allizom.org/collage/f7ad6331ff0c/ [HTTP/1.1 500 INTERNAL SERVER ERROR 715ms]

Comment 3

[[:brez]]

Have we confirmed that the message queue is running?

Comment 4

[[:brez]]

While working an image directory strategy I found an issue with building collages related to paths - still looking into but a likely cause (tho let's still confirm that the message queue is running on staging)

Comment 5

[[:brez]]

The 500 error is fixed with:

https://github.com/mozilla/webifyme/commit/994830ef1b037b1d964677df0d7626a2242bf87f

Does anyone have a screenshot (or?) of when it wasn't broken?  i.e. I'm not sure what not-broken looks like..

Comment 6

[krupa raj[:krupa]]

> Does anyone have a screenshot (or?) of when it wasn't broken?  i.e. I'm not
> sure what not-broken looks like..

Earlier, the collages were available at the TBG staging(http://209.20.77.14/)

Comment 7

[krupa raj[:krupa]]

example: http://209.20.77.14/collage/3b44d6fd906f/

Comment 8

[[:brez]]

This is still in progress, I fixed the 500 error (technically a different bug)..

Comment 9

[[:brez]]

Managed to figure out that this is caused because the default images aren't sized properly when they are loaded from the fixtures - should be able to figure exactly what's going wrong in the morning

Comment 10

[Austin King [:ozten]]

FWIW: In my dev environment I can run through and get the mixed-up collage, but...

I never see any tasks go into the queue. Or atleast watching the log from python ff4/manage.py celeryd --verbosity=2 --loglevel=DEBUG

'Consumer: Ready to accept tasks!' - then I run through quiz, title the collage... and no change. Is this expected behavior?

Comment 11

[[:brez]]

Updated fixtures with correct image sizes:

https://github.com/mozilla/webifyme/commit/75036240c0d56ebccbba0e0136784754b0f4526d

Please note - IMPORTANT- you need to drop your database and reinit in order to see this fix.

Comment 12

[Austin King [:ozten]]

TODO - File an IT Request to reinit the db. Operations currently focusing on Markup, so I"ll hold off on that step.

Comment 13

[Austin King [:ozten]]

I tested -dev and it still looks broken. Filed Bug#658994 to have the db fixed.

Comment 14

[[:brez]]

Austin - find me in IRC and we can confirm your database is correct.

Comment 15

[Austin King [:ozten]]

Attachment: Screenshot of https://webifyme-dev.allizom.org showing db work is needed

Comment 16

[[:brez]]

Database has *not been updated -- it took a while to understand what was going on but because the fixture data didn't have the size data, it defaults to 50 (or 75) which is why it ends up looking like lots of small blocks - reinit database and this will be fixed.

Comment 17

[Austin King [:ozten]]

Hmm reopening per Bug#656437Comment#7.

Comment 18

[[:brez]]

This is because the you haven't set the images sizes as specified in 656437 - I don't have access to this server to run it , i.e. reopening this is redundant and assigning to me isn't a good idea because I can't address it.

Comment 19

[Austin King [:ozten]]

If that command needs any arguments, can you comment in Bug#656437?

Comment 20

[Austin King [:ozten]]

From Bug#663523Comment#6

> [root@x ~]# cd /data/www/python/webifyme.org/webifyme/ff4/
> [root@x ff4]# ./manage.py set_image_sizes
> Saving sizes...
> missing

Also collage still looks the same.
https://webifyme-dev.allizom.org/collage/ff56103d0056/

Adam or Brez, thoughts?

Comment 21

[Adam Miller]

Looks like that script didn't totally work. I created a new collage and a few were larger but still cropped versions, and even fewer were actually their correct size. 

Can you dump the things_images table and reload things/fixtures/images.yaml? I updated that a few weeks ago with the correct image sizes. The set_image_sizes task is supposed to make it easy but I didn't write it and am not sure why it doesn't work consistently.

Comment 22

[Austin King [:ozten]]

(In reply to comment #21)
It would be really helpful if you can document the environmental change.

Example:
mysql webifyme-db
drop database foo;
create database foo;
# exit mysql
cd /path/to/webifyme/ff4
./manage.py 
python ff4/manage.py syncdb
python ff4/manage.py migrate
python ff4/manage.py loaddata ff4/things/fixtures/*.yaml

Can you confirm these steps? We'll want to document these kinds of changes, so I can rely them to Operations. thanks!

Comment 23

[Adam Miller]

how about....

mysql webifyme-db
delete from things_images;
#exit mysql
cd /path/to/webifyme/ff4
python ff4/manage.py loaddata ff4/things/fixures/images.yaml

No need to dump the entire DB and run the migrations again, just need to get the right data in the things_images table.

Comment 24

[[:brez]]

Let me know what needs to be done here - not really clear..

Comment 25

[Austin King [:ozten]]

I've reopened Bug#658994 with the steps from comment#23.

This bug is marked 'depends on' 658994, so we'll get an update once it's been closed.

Comment 26

[Austin King [:ozten]]

I mean bug#663523. Bug#658994 looks ancient, I'll close it.

Comment 27

[Austin King [:ozten]]

(In reply to comment #23)
Done. 

https://webifyme-dev.allizom.org/collage/ff56103d0056/ still looks fragmented.

Comment 28

[[:brez]]

Whats going on here is very simple  - the widths and heights of the images are missing / set to default in the database (things_images table) - there are two options:

1. Reinstall the fixtures
2. Run ./manage set_image_sizes

Unless I'm given direct access to this server, I can't fix i.e. assigning this to me means it won't get done, reassigning to ozten so he can determine the appropriate person to address.

Comment 29

[Austin King [:ozten]]

As documented, both steps where taken.

Can you repro the problem and test those steps?

Comment 30

[[:brez]]

Can you send me the database you're using?  I can provide the steps to fix.

Comment 31

[Austin King [:ozten]]

(In reply to comment #30)
Good call. Filed Bug#664445.

Comment 32

[[:brez]]

Taking this back - got the database..

Comment 33

[[:brez]]

Attachment: Seems to have magically fixed itself..

Comment 34

[[:brez]]

The values in the database are correct - not sure what happened but it's not broken on webifyme-dev anymore so closing..

Comment 35

[krupa raj[:krupa]]

woks fine now