656105 - Opening links in a new tab does not activate the tab

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

In Firefox 4, at least, /goto-url-newtab is not focusing the tab unless the Firefox Tabs option "When I open a link in a new tab, switch to it immediately" is selected (not default). We should use a newer API or figure out how to focus the tab reliably.

Comment 1

[James Ross]

So far the best I've come up with is:

window.gBrowser.selectedTab = window.gBrowser.addTab(uriString);

All the normal functions, including FUEL, follow the preference, meaning the tab will not be focused by default.

It really needs to work like OS default browser URL opening in terms of behaviour (but without going via the OS).

Comment 2

[James Ross]

And right after posting that, I find it, sigh.

openUILinkIn(uriString, "tab");

This comes from chrome://browser/content/utilityOverlay.js, which we include for FF, and deals with focusing in all cases - and focusing the window. We can also use openUILinkIn(uriString, "window") for /goto-url-newwin. Excellent.

Comment 3

[James Ross]

Attachment: Use openUILinkIn when available

Comment 4

[James Ross]

http://hg.mozilla.org/chatzilla/rev/5f59aea55af6