656128 - 500/Internal Server Error with manipulated /linear/ trailing path

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://markup-dev.allizom.org/en-US/#/linear/8CK9x gives me a 500 Internal Server Error (but I don't yet have a Django stack).

Comment 1

[Adam Miller]

Not of major importance, IMO, but this case could be handled better. I'll work on it.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

If you can hold off fixing this until we've investigated why we're not getting Django tracebacks emailed to us when we hit this exception, that'd be appreciated (bug 656345).

Comment 3

[Austin King [:ozten]]

(In reply to comment #0)
What are the repro steps, so I can reproduce in my local environment?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> (In reply to comment #0)
> What are the repro steps, so I can reproduce in my local environment?

Wouldn't it just be running against your local instance, with path: /en-US/#/linear/8CK9x, or something similar?

Comment 5

[Austin King [:ozten]]

Works for me.

Perhaps there is data or conditions that trigger the error?

Comment 6

[[:brez]]

Was looking into this to recreate 656345 and discovered that it's really a 404 error - when a mark is not found it returns a HttpResponseServerError (500) - should probably return an XHR of 404 and the view would behave accordingly.. ?

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> Was looking into this to recreate 656345 and discovered that it's really a
> 404 error - when a mark is not found it returns a HttpResponseServerError
> (500) - should probably return an XHR of 404 and the view would behave
> accordingly.. ?

Seems right to me.

Comment 9

[[:brez]]

Ok - will send back 404 instead..

Comment 10

[[:brez]]

Half the fix is here

https://github.com/mozilla/markup/commit/be406afc42a19885e667f97ba4d7e10047607dc8

Adam will update the view to handle 404s - leaving as open

Comment 11

[Adam Miller]

Adam updated the view to handle 404s - resolving as fixed. 

https://github.com/mozilla/markup/commit/06188ef483ca75c70bbd94ba3b1b7568641ab9ab

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on:

[13:34:12.026] GET https://markup-dev.allizom.org/requests/marks_by_reference?reference=8CK9x&include_forward=20&include_back=20&include_mark=1 [HTTP/1.1 404 NOT FOUND 4335ms]