Closed Bug 656152 Opened 10 years ago Closed 10 years ago

Improve string for 32-bit plugin restart

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 6

People

(Reporter: limi, Assigned: peregrino)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently, the string to restart in 32-bit mode for plugin compatibility is a bit overly aggressive. It implies that you *have* to restart.

Current text:
"This page requires a plugin that can only run in 32-bit mode"

Proposed new text:
"This page asks to use a plugin that can only run in 32-bit mode"

The difference is that you can very often view and interact with a page fine (see pages on microsoft.com that seem to insist on using Silverlight no matter whether the content actually uses it), but suggests something you can do in case there's something missing on the page.
OS: Mac OS X → All
Hardware: x86 → All
Attached patch proposed patch (obsolete) — Splinter Review
Am I missing something? Who should review this?
Comment on attachment 531489 [details] [diff] [review]
proposed patch

Sadly yes. Whenever we change strings we also have to change the string's key to make sure that localizers spot that the text has changed and that they need to re-translate it.

Consult the module owners list for people to review patches, see https://wiki.mozilla.org/Modules/Firefox for browser/... stuff
Attachment #531489 - Flags: review-
Attached patch new patchSplinter Review
new patch, change in string suffix.
Attachment #531489 - Attachment is obsolete: true
Attachment #531496 - Flags: review?(gavin.sharp)
Attachment #531496 - Flags: review?(gavin.sharp) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/d244e7fe6361
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110629 Firefox/7.0a1

Can some of you suggest such a page in order for me to verify whether this issue was fixed or not?

Thanks!
Can you please post some STR in order to verify this as being resolved.
thanks.
You need to log in before you can comment on or make changes to this bug.