656153 - Search box on wiki header not displaying properly

Status: RESOLVED FIXED

(Websites :: wiki.mozilla.org, defect)

Description

[David Boswell]

Attachment: Screenshot of wiki header with display issue

The search box in the header on the default wiki skin isn't displaying properly.

Instead of on arrow at the end of the search box the word 'search' is being displayed.

Compare this to the search box on www.mozilla.org which should be the same as the wiki.  The word 'search' is in the search box and there is an arrow at to the right of the search form field.

Comment 1

[Pierros Papadeas [:pierros]]

Attachment: FIx on gmo.php

Hey David,

Here is the fix on the gmo.php . Apparently there was a directory missing on the path of the icon.

Comment 2

[David Boswell]

Pierros, great.  I can't do anything with that though.  Milos, can you apply this fix or give Pierros access to do that?  Thanks.

Comment 3

[William Quiviger [:williamq]]

I second that. Milos, i know you're totally swamped right now so please don't hesitate to give Pierros access so he can fix these.

Thanks sooo much!

Comment 4

[Milos Dinic [:Milos]]

Fix landed in r91941. CCing mcoates to see if we need a secreview for this one.

Comment 5

[Michael Coates [:mcoates] (acct no longer active)]

(In reply to comment #4)
> Fix landed in r91941. CCing mcoates to see if we need a secreview for this
> one.

We don't need to secreview all code changes. In fact, that's not even feasible given the number of projects we have.

Instead we review new plugins that are added to the wiki, new web applications, and any code where there is security concern brought to our attention (e.g. if the developer has security concerns please feel free to ask us for our opinion).

Comment 6

[Jake Maul [:jakem]]

This is fixed for header(), but there's a reference to $wgStylePath in footer() as well that needs the same treatment.

[17:37:31.672] GET https://wiki.mozilla.org/Gmo/img/screen/template/screen/logo_footer.png [HTTP/1.1 404 Not Found 179ms]

The reference is on line 268 of gmo.php.

Comment 8

[Milos Dinic [:Milos]]

Committed revision r96426. Thanks!