Closed Bug 656205 Opened 9 years ago Closed 9 years ago

Remove unused browser migration code (MacIE, iCab, OmniWeb, Dogbert a.k.a. Netscape, and Camino)

Categories

(Firefox :: Migration, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 6

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

Final version of MacIE was released as 2003 and there is no Intel version release.

Also, target platform of Firefox trunk is Intel version and OSX 10.5 or later.  I think that MacIE migratory doesn't need.
Indeed, most of the migration code is crufty, old, and no longer useful. Removing MacIE would be a good start, and if you're motivated to purge some of the others that would be great too!
(In reply to comment #1)
> Indeed, most of the migration code is crufty, old, and no longer useful.
> Removing MacIE would be a good start, and if you're motivated to purge some
> of the others that would be great too!

At least, no one needs old Phoenix migration.  I will file a new bug for it.
I guess ICab OmniWeb and Dogbert can go as well.
I'm available to review if browser peers are fine with that.
We should remove iCab, OmniWeb and Camino migration because this implementation is template only and commented in XUL.  So, it doesn't work.

http://mxr.mozilla.org/mozilla-central/source/browser/components/migration/content/migration.xul?mark=76-80#76
Assignee: nobody → m_kato
Status: NEW → ASSIGNED
OS: Mac OS X → All
Summary: Remove MacIE migrator → Remove unused browser migration code (MacIE, iCab, OmniWeb, Dogbert and Camino)
Attached patch fixSplinter Review
Attachment #532577 - Flags: review?(mak77)
Comment on attachment 532577 [details] [diff] [review]
fix

Review of attachment 532577 [details] [diff] [review]:
-----------------------------------------------------------------

I've done some search in mxr and looks like you removed all the relations, nice!

r=me with the below addressed or answered:

::: browser/components/migration/src/nsOperaProfileMigrator.h
@@ +45,5 @@
>  #include "nsISupportsArray.h"
>  #include "nsStringAPI.h"
>  #include "nsTArray.h"
>  #include "nsINavHistoryService.h"
> +#include "nsIStringBundle.h"

why this isolated change in the Opera migrator?
Attachment #532577 - Flags: review?(mak77) → review+
(In reply to comment #6)
> Comment on attachment 532577 [details] [diff] [review] [review]
> fix
> 
> Review of attachment 532577 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> I've done some search in mxr and looks like you removed all the relations,
> nice!
> 
> r=me with the below addressed or answered:
> 
> ::: browser/components/migration/src/nsOperaProfileMigrator.h
> @@ +45,5 @@
> >  #include "nsISupportsArray.h"
> >  #include "nsStringAPI.h"
> >  #include "nsTArray.h"
> >  #include "nsINavHistoryService.h"
> > +#include "nsIStringBundle.h"
> 
> why this isolated change in the Opera migrator?

If nothing, it will causes build break (http://tinderbox.mozilla.org/showlog.cgi?log=Try/1305523324.1305528492.5285.gz) when compiling nsModule.cpp.
Ah, I see.
OperaProfileMigrator.cpp includes nsIStringBundle.h before its own header
62 #include "nsIStringBundle.h"
63 #include "nsISupportsPrimitives.h"
64 #include "nsNetUtil.h"
65 #include "nsOperaProfileMigrator.h"
Instead in nsModule.cpp we include only the header and nsIStringBundle.h was included by a previous migrator header that you removed.
The trybuild was a really good idea! :)
http://hg.mozilla.org/mozilla-central/rev/676006c214ad
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Blocks: 578270
Duplicate of this bug: 578270
Blocks: 608947
Blocks: 236305
Summary: Remove unused browser migration code (MacIE, iCab, OmniWeb, Dogbert and Camino) → Remove unused browser migration code (MacIE, iCab, OmniWeb, Dogbert a.k.a. Netscape, and Camino)
You need to log in before you can comment on or make changes to this bug.