Last Comment Bug 656231 - Cleanup the HUD object properties, add xul:tab reference
: Cleanup the HUD object properties, add xul:tab reference
[fixed by bug 673148]
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
-- normal (vote)
: Firefox 15
Assigned To: Mihai Sucan [:msucan]
: (Unavailable until Apr 3) [:bgrins]
Depends on: async-webconsole
Blocks: consolecleanup
  Show dependency treegraph
Reported: 2011-05-11 02:34 PDT by Mihai Sucan [:msucan]
Modified: 2012-06-02 04:01 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Description User image Mihai Sucan [:msucan] 2011-05-11 02:34:50 PDT
The HeadsUpDisplay object holds a bunch of references we shouldn't keep: chromeDocument, contentWindow, notificationBox and so on. We can get rid of all these and keep only one reference to the xul:tab object associated to the HUD.

The xul:tab object is needed for a cleaner HUDService initialization and shutdown, opening and closing of HUDs would also be slimmer.

Through out the code we do, indeed, make use of chromeDocument, notificationBox and so on. However, if we have the xul:tab object ref we can have simple/trivial getters to the rest of the objects we need.

(this is follow up from bug 577721)
Comment 1 User image Mihai Sucan [:msucan] 2011-09-17 12:30:56 PDT
This is going to be fixed by bug 673148. The changes needed to use xul:tab refs were among the first changes I did when I submitted the first WIP patch there.

Note You need to log in before you can comment on or make changes to this bug.