Closed Bug 656231 Opened 10 years ago Closed 9 years ago

Cleanup the HUD object properties, add xul:tab reference

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: msucan, Assigned: msucan)

References

Details

(Whiteboard: [fixed by bug 673148])

The HeadsUpDisplay object holds a bunch of references we shouldn't keep: chromeDocument, contentWindow, notificationBox and so on. We can get rid of all these and keep only one reference to the xul:tab object associated to the HUD.

The xul:tab object is needed for a cleaner HUDService initialization and shutdown, opening and closing of HUDs would also be slimmer.

Through out the code we do, indeed, make use of chromeDocument, notificationBox and so on. However, if we have the xul:tab object ref we can have simple/trivial getters to the rest of the objects we need.

(this is follow up from bug 577721)
This is going to be fixed by bug 673148. The changes needed to use xul:tab refs were among the first changes I did when I submitted the first WIP patch there.
Component: Developer Tools → Developer Tools: Console
Depends on: async-webconsole
QA Contact: developer.tools → developer.tools.console
Assignee: nobody → mihai.sucan
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 673148]
Target Milestone: --- → Firefox 15
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.