Cleanup the HUD object properties, add xul:tab reference

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: msucan, Assigned: msucan)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed by bug 673148])

(Assignee)

Description

6 years ago
The HeadsUpDisplay object holds a bunch of references we shouldn't keep: chromeDocument, contentWindow, notificationBox and so on. We can get rid of all these and keep only one reference to the xul:tab object associated to the HUD.

The xul:tab object is needed for a cleaner HUDService initialization and shutdown, opening and closing of HUDs would also be slimmer.

Through out the code we do, indeed, make use of chromeDocument, notificationBox and so on. However, if we have the xul:tab object ref we can have simple/trivial getters to the rest of the objects we need.

(this is follow up from bug 577721)
(Assignee)

Comment 1

6 years ago
This is going to be fixed by bug 673148. The changes needed to use xul:tab refs were among the first changes I did when I submitted the first WIP patch there.

Updated

6 years ago
Component: Developer Tools → Developer Tools: Console
Depends on: 673148
QA Contact: developer.tools → developer.tools.console
(Assignee)

Updated

5 years ago
Assignee: nobody → mihai.sucan
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 673148]
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.