656286 - virus scan e-mails from staging are confusing

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P5)

Description

[[e-mail] (:bhearsum)]

I did part of staging release today and a AV vendor e-mail went to [e-mail]. This is good, but the subject is confusing. In staging/preproduction it would be helpful to tag them the same way we do other release mails: with [staging] or [preprod-release].

Comment 1

[[e-mail] (:bhearsum)]

Mass move of bugs to Release Automation component.

Comment 2

[Massimo Gervasini [:massimo]]

Attachment: patch for bug 656286

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 669926 [details] [diff] [review]
patch for bug 656286

This looks OK, but let's make sure the behaviour in consistent with similar options in createReleaseMessage by factoring out to getSubject() and getMessageTag():
https://github.com/mozilla/buildbotcustom/blob/master/process/release.py#L164
https://github.com/mozilla/buildbotcustom/blob/master/process/release.py#L205

Comment 4

[Massimo Gervasini [:massimo]]

Attachment: added getMessageTag()

added getMessageTag()

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 672540 [details] [diff] [review]
added getMessageTag()

Review of attachment 672540 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/release.py
@@ +271,5 @@
> +    def getMessageTag():
> +        return releaseConfig.get('messagePrefix', '[release] ')
> +
> +    def getSubject():
> +        subject = getMessageTag() + '%(productName)s %(version)s release'

We should actually drop this, since it's not used everywhere, and put this assignment create in createReleaseAVVendorsMessage. Looks fine otherwise.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 672540 [details] [diff] [review]
added getMessageTag()

Need the below addressed, removing review.

::: process/release.py
@@ +271,5 @@
> +    def getMessageTag():
> +        return releaseConfig.get('messagePrefix', '[release] ')
> +
> +    def getSubject():
> +        subject = getMessageTag() + '%(productName)s %(version)s release'

We should actually drop this, since it's not used everywhere, and put this assignment create in createReleaseAVVendorsMessage. Looks fine otherwise.

Comment 7

[Massimo Gervasini [:massimo]]

Attachment: patch for 656286

resending patch. In the last upload I have sent the wrong one. My fault.

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 673961 [details] [diff] [review]
patch for 656286

Review of attachment 673961 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good now, thanks! I landed this on the default branch.

Comment 9

[Rail Aliiev [:rail]]

In production