Closed
Bug 656298
Opened 13 years ago
Closed 13 years ago
Addon bar keeps displaying on new window or restart event if user hide it
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ochameau, Assigned: ochameau)
Details
Attachments
(1 file, 1 obsolete file)
|
2.37 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
http://groups.google.com/group/mozilla-labs-jetpack/browse_thread/thread/6399e0c2d0c7581c We have this bug again. We were not forcing firefox to save "currentset" attribute. It was saved only when user start customizing his toolbar.
Attachment #531631 -
Flags: review?(dietrich)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 531631 [details] [diff] [review] Fix this! can you please add a test? shouldn't be too hard to do - see existing widget tests for how to toggle add-on bar, etc.
Attachment #531631 -
Flags: review?(dietrich) → review-
|
Assignee | |
Comment 2•13 years ago
|
||
Assignee: nobody → poirot.alex
Attachment #531631 -
Attachment is obsolete: true
Attachment #532660 -
Flags: review?(dietrich)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 532660 [details] [diff] [review] Patch with an unit test looks good, r=me. thanks for adding a test!
Attachment #532660 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://github.com/mozilla/addon-sdk/commit/8d01e9c11d905a9bc1553fb2a9bc29a605ad6dc8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•