JSClass.delProperty should allow properties to not be deleted

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: robarnold, Assigned: robarnold)

Tracking

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jorendorff][spidernode][inbound], URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Per-docs, this should be allowed but the code doesn't check the result of the property handler. Currently this can only be done via throwing an exception from within the delProperty handler.
(Assignee)

Comment 1

6 years ago
Created attachment 531839 [details] [diff] [review]
Naive implementation

A quick scan via mxr shows only two custom delete property hooks and neither sets *vp.
Assignee: general → tellrob
Status: NEW → ASSIGNED
Attachment #531839 - Flags: review?(jorendorff)
Comment on attachment 531839 [details] [diff] [review]
Naive implementation

I thought I plus'd this a long time ago.

I note that this leaves a delProperty call in Object.defineProperty (DefinePropertyOnObject, specifically) unchanged. I think that's OK. We're really after V8 API parity here.
Attachment #531839 - Flags: review?(jorendorff) → review+
Rob, did we not need this after all? It hasn't landed. Checkin-needed?
(Assignee)

Comment 4

6 years ago
checkin-needed - I haven't found the time to pull a t-m tree and push (or actually figure out where it should land now).
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/cdad0b82ec90
Keywords: checkin-needed
Whiteboard: [mentor=jorendorff][spidernode] → [mentor=jorendorff][spidernode][inbound]
http://hg.mozilla.org/mozilla-central/rev/cdad0b82ec90
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.