Closed
Bug 656320
Opened 13 years ago
Closed 13 years ago
JSClass.delProperty should allow properties to not be deleted
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: robarnold, Assigned: robarnold)
References
()
Details
(Whiteboard: [mentor=jorendorff][spidernode][inbound])
Attachments
(1 file)
|
499 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Per-docs, this should be allowed but the code doesn't check the result of the property handler. Currently this can only be done via throwing an exception from within the delProperty handler.
|
Assignee | |
Comment 1•13 years ago
|
||
A quick scan via mxr shows only two custom delete property hooks and neither sets *vp.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 531839 [details] [diff] [review] Naive implementation I thought I plus'd this a long time ago. I note that this leaves a delProperty call in Object.defineProperty (DefinePropertyOnObject, specifically) unchanged. I think that's OK. We're really after V8 API parity here.
Attachment #531839 -
Flags: review?(jorendorff) → review+
|
|
||
Comment 3•13 years ago
|
||
Rob, did we not need this after all? It hasn't landed. Checkin-needed?
|
|
Assignee | |
Comment 4•13 years ago
|
||
checkin-needed - I haven't found the time to pull a t-m tree and push (or actually figure out where it should land now).
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/cdad0b82ec90
Keywords: checkin-needed
Whiteboard: [mentor=jorendorff][spidernode] → [mentor=jorendorff][spidernode][inbound]
|
||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/cdad0b82ec90
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•