[RFE] unchecking "use pswd mgr to remember these values" should cause them to be forgotten

VERIFIED FIXED

Status

SeaMonkey
Passwords & Permissions
--
enhancement
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Max Christian, Assigned: Max Christian)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

17 years ago
Now that the "remember these values" checkbox is checked if a username/password
has been recalled (bug 40122), if the user unchecks the box and clicks OK, then
I suggest that the username/password combination that was recalled should be
forgotten (not recalled in future browser sessions).

To clarify, this is what I think should happen:
 1. Run Mozilla, login to a page with "remember" checked.
 2. Restart Mozilla.
 3. Go back to same page, login gets remembered.  Uncheck the box and click OK.
 4. View page OK.
 5. Restart Mozilla.
 6. Go back to same page, no login is remembered.

This is the way that Internet Explorer works, for what it's worth.  I think it
makes sense because (i) it's an intuitive way for the user to get a login
forgotten, and (ii) otherwise the checkbox has no function in the situation
where a login has been remembered and the user doesn't change the user/pass.
(Assignee)

Updated

17 years ago
Depends on: 40122
(Assignee)

Comment 1

17 years ago
Created attachment 22693 [details] [diff] [review]
proposed fix, using cvs diff -u

Comment 2

17 years ago
Changing to Enhancement and adding Patch keyword. Marking NEW, I agree with the
bug report btw.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: patch
Summary: unchecking "use pswd mgr to remember these values" should cause them to be forgotten → [RFE] unchecking "use pswd mgr to remember these values" should cause them to be forgotten

Comment 3

17 years ago
I see the following problem with this patch:

You moved Wallet_GiveCaveat outside the "if checked" statement.  That means we 
might be giving the caveat even though we are not going to attempt to save the 
username/password.  That caveat should only be given when we know for sure that 
the password is actually being saved.

If Wallet_GiveCaveat is restored to its previous position, and assuming that you 
have tested this, then r=morse.
(Assignee)

Comment 4

17 years ago
Created attachment 22701 [details] [diff] [review]
updated patch with call to Wallet_GiveCaveat in the right place

Comment 5

17 years ago
r=morse for the corrected patch
I see no point in adding si_ForgetSignonDataFromBrowser when you could just call
si_RemoveUser.  The extra functional layer adds no value, as si_RemoveUser also
checks si_GetSignonRememberingPref() and returns false right away if that
predicate returns false.

/be
(Assignee)

Comment 7

17 years ago
Created attachment 23062 [details] [diff] [review]
version with no wrapper for si_RemoveUser

Comment 8

17 years ago
Great, that's much simpler.  r=morse.
Minimal, nice -- sr=brendan@mozilla.org.

/be
(Assignee)

Comment 10

17 years ago
Fix checked in 25/1/01, bug closed.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
Verified Win2k build 2001022007
Verified Linux build 2001022012
Verified Mac build 2001022013
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.