656365 - Creating an arguments object shouldn't require a parent, only a callee

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

The one is redundant with the other, so we only need callee to get the job done.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Try's testing this now, and I expect it'll be golden.

http://tbpl.mozilla.org/?tree=Try&rev=5308e1f0b72a

Comment 2

[Nicholas Nethercote [inactive]]

Golden?  You must be running a new version of TBPL :P

Comment 3

[Jeff Walden [:Waldo]]

Har har.

Turns out "it" is not golden, but I highly doubt it's this patch.  I'm bisecting through the few changes it might be (all but the last five or so have previously tryservered green) in that push to figure out which is at issue.  That series of patches minus the one here still crashes, and one five or so back doesn't, so it's an intermediate patch with a bug, should be easy enough to spot.  It doesn't matter much anyway, tho, because I need so many of the other changes to land first, and it's not really worth the trouble to move the patch further up the queue to push it sooner.

Comment 4

[Jeff Walden [:Waldo]]

Yeah, not a problem with this patch, just a wider-flung change than possible in bug 655907.

Comment 5

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/993f0935af4c

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/993f0935af4c