Closed Bug 656404 Opened 8 years ago Closed 8 years ago

Update the results dashboard to indicate if the application is restarted between tests

Categories

(Mozilla QA Graveyard :: Mozmill Result Dashboard, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

Attachments

(1 file, 2 obsolete files)

We're changing endurance tests to restart the application between each test by default, but the user can override this setting. We need to update the dashboard to indicate if the application was restarted.
Comment on attachment 531702 [details] [diff] [review]
Update the results dashboard to indicate if the application is restarted between tests. v1

Review of attachment 531702 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, r+
Attachment #531702 - Flags: review?(anthony.s.hughes) → review+
Attachment #531702 - Flags: review?(hskupin) → review+
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13565923
Updated based on changes during review process of dependent bug 656393.
Attachment #531702 - Attachment is obsolete: true
Attachment #533481 - Flags: review?(hskupin)
Comment on attachment 533481 [details] [diff] [review]
Update the results dashboard to indicate if the application is restarted between tests. v1.1

>+++ b/_attachments/js/dashboard.js
>@@ -1341,6 +1341,7 @@ var MAX_CHART_CHECKPOINTS = 450;
> 
>         context.delay = resp.endurance.delay * 1/1000;
>         context.iterations = resp.endurance.iterations;
>+        context.restart = resp.endurance.restart ? "Yes" : "No";

You can do that completely in the template itself. No need to have extra code in the dashboard.js file.
Attachment #533481 - Flags: review?(hskupin) → review-
(In reply to comment #5)
> Comment on attachment 533481 [details] [diff] [review] [review]
> Update the results dashboard to indicate if the application is restarted
> between tests. v1.1
> 
> >+++ b/_attachments/js/dashboard.js
> >@@ -1341,6 +1341,7 @@ var MAX_CHART_CHECKPOINTS = 450;
> > 
> >         context.delay = resp.endurance.delay * 1/1000;
> >         context.iterations = resp.endurance.iterations;
> >+        context.restart = resp.endurance.restart ? "Yes" : "No";
> 
> You can do that completely in the template itself. No need to have extra
> code in the dashboard.js file.

You're absolutely right. Done. :)
Attachment #533481 - Attachment is obsolete: true
Attachment #533605 - Flags: review?(hskupin)
Comment on attachment 533605 [details] [diff] [review]
Update the results dashboard to indicate if the application is restarted between tests. v1.2

Looks good. Please land this patch.
Attachment #533605 - Flags: review?(hskupin) → review+
All changes have been pushed to production now.
Keywords: push-needed
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.