656459 - use build/tools for staging buildbot-configs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

I'd like to also 

    tools_repo = '%s%s' % (branchConfig['hgurl'],
                           releaseConfig.get('tools_repo_path', 
                               branchConfig['build_tools_repo_path']))

in buildbotcustom.process.release.generateReleaseBranchObjects, so we can override the tools_repo_path back to stage-ffxbld/tools for staging releases.

Comment 1

[Aki Sasaki (not active)]

Attachment: configs changes

Comment 2

[Aki Sasaki (not active)]

Attachment: generateReleaseBranchObjects changes

The upside to this is that both "normal" staging nightly/depend builds and "normal" staging release builds work correctly out of the box.

The downside might be if someone wants to change the build/tools repo to their own user repo, and does a staging release and forgets that it's set to stage-ffxbld/tools in the staging release config.

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 531776 [details] [diff] [review]
configs changes

http://hg.mozilla.org/build/buildbot-configs/rev/316094512022

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 531777 [details] [diff] [review]
generateReleaseBranchObjects changes

http://hg.mozilla.org/build/buildbotcustom/rev/300f5f60a1a4

Comment 5

[[e-mail] (:bhearsum)]

Thanks for doing this Aki! Could you update https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:Documentation#Buildbot_configs when this lands, too?

Comment 6

[Aki Sasaki (not active)]

(In reply to comment #5)
> Thanks for doing this Aki! Could you update
> https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:
> Documentation#Buildbot_configs when this lands, too?

Done.

Though if we're changing repo paths to use user repos on every staging release, suddenly the staging release build_tools_repo_path becomes an extra step rather than a convenience.

We can remove those if people don't want it ?

Comment 7

[[e-mail] (:bhearsum)]

(In reply to comment #6)
> (In reply to comment #5)
> > Thanks for doing this Aki! Could you update
> > https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:
> > Documentation#Buildbot_configs when this lands, too?
> 
> Done.
> 
> Though if we're changing repo paths to use user repos on every staging
> release, suddenly the staging release build_tools_repo_path becomes an extra
> step rather than a convenience.
> 
> We can remove those if people don't want it ?

As it stands now, the staging configs are set-up to work OOB in stage-ffxbld, so I think this is good. If we decide to change them to be more OOB friendly to personal user repositories, we can change this at that point.

re: your documentation edit, I still see build_tools_repo_path being modified in the staging_config.py diff. Isn't that unnecessary now that this bug has landed? (Honest question.)

Comment 8

[Aki Sasaki (not active)]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Thanks for doing this Aki! Could you update
> > > https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:
> > > Documentation#Buildbot_configs when this lands, too?
> > 
> > Done.
> > 
> > Though if we're changing repo paths to use user repos on every staging
> > release, suddenly the staging release build_tools_repo_path becomes an extra
> > step rather than a convenience.
> > 
> > We can remove those if people don't want it ?
> 
> As it stands now, the staging configs are set-up to work OOB in
> stage-ffxbld, so I think this is good. If we decide to change them to be
> more OOB friendly to personal user repositories, we can change this at that
> point.

Cool.

> 
> re: your documentation edit, I still see build_tools_repo_path being
> modified in the staging_config.py diff. Isn't that unnecessary now that this
> bug has landed? (Honest question.)

I'm not sure.
I only did that for completeness, since I don't want people to set up an entire set of user repos for themselves and forget about the tools repo during a staging release.

Is that helpful or harmful?

Comment 9

[[e-mail] (:bhearsum)]

(In reply to comment #8)
> (In reply to comment #7)
> > 
> > re: your documentation edit, I still see build_tools_repo_path being
> > modified in the staging_config.py diff. Isn't that unnecessary now that this
> > bug has landed? (Honest question.)
> 
> I'm not sure.
> I only did that for completeness, since I don't want people to set up an
> entire set of user repos for themselves and forget about the tools repo
> during a staging release.
> 
> Is that helpful or harmful?

Sorry, I'm having trouble connecting your response to my question...what I'm not clear about is whether or not the build_tools_repo_path in staging_config.py still affects releases or not. If it does, the docs seem fine; if it doesn't, we can remove that part from the docs?

Comment 10

[Aki Sasaki (not active)]

(In reply to comment #9) 
> Sorry, I'm having trouble connecting your response to my question...what I'm
> not clear about is whether or not the build_tools_repo_path in
> staging_config.py still affects releases or not. If it does, the docs seem
> fine; if it doesn't, we can remove that part from the docs?

Oh, I think I was completely misunderstanding your question.
I blame morning.
Edited.

Comment 11

[[e-mail] (:bhearsum)]

I think a few things were missed here; patch incoming.

Comment 12

[[e-mail] (:bhearsum)]

Attachment: use releaseConfig['build_tools_repo_path'] everywhere, when it exists

Comment 13

[Aki Sasaki (not active)]

Comment on attachment 536890 [details] [diff] [review]
use releaseConfig['build_tools_repo_path'] everywhere, when it exists

Oops.

Comment 14

[[e-mail] (:bhearsum)]

This hit production today.