Open Bug 656463 Opened 9 years ago Updated 7 years ago

Port browser parts of |Bug 631374 - Adding or removing tags in the selector listbox always scrolls to top| to SeaMonkey

Categories

(SeaMonkey :: Bookmarks & History, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: InvisibleSmiley, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [2012 Fall Equinox])

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 631374 contained changes to both the Places back-end and the Firefox front-end (browser/.../editBookmarkOverlay.js) plus a new chrome test (test_bug631374_tags_selector_scroll.xul). We should at least port the front-end part and maybe also the test.
Attachment #531767 - Flags: review?(neil)
Assignee: nobody → jh
Status: NEW → ASSIGNED
Comment on attachment 531767 [details] [diff] [review]
patch

>+    let selectedIndex = tagsSelector.selectedIndex;
We don't really need to know the selected index, all the relevant methods work just as well on items. In fact, we can go one better and set the value attribute on the listitems thus allowing us to persist the selection by value.

>+    // Restore position.
>+    // The listbox allows to scroll only if the required offset doesn't
>+    // overflow its capacity, thus need to adjust the index for removals.
>+    firstIndex =
>+      Math.min(firstIndex,
>+               tagsSelector.itemCount - tagsSelector.getNumberOfVisibleRows());
I guess if the item count is less than the number of visible rows then there's no scrolling to do so it doesn't matter what index we pass.
Attachment #531767 - Flags: review?(neil) → review-
Reality update: Free to take.
Assignee: jh → nobody
Status: ASSIGNED → NEW
Issue with jumps after checking the tag still present in current nightly
User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 SeaMonkey/2.15a1
Build identifier: 20120921003032
Whiteboard: [2012 Fall Equinox]
You need to log in before you can comment on or make changes to this bug.