Closed Bug 656708 Opened 12 years ago Closed 12 years ago

Channel.URI is undefined during TPS run

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: rnewman, Assigned: rnewman)

Details

(Whiteboard: [fixed in services][qa-])

Attachments

(2 files, 1 obsolete file)

Proposed patch. v2
1.86 KB, patch
philikon
: review+
Details | Diff | Splinter Review
screenshot
41.58 KB, image/png
Details 
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "channel.URI is undefined" {file: "resource://services-sync/resource.js" line: 546}]' when calling method: [nsIStreamListener::onStopRequest]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************
Yeah, this isn't supposed to happen; we never create a channel without a URI.

CrossWeave ends up dumping a lot of errors like this to the log:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "Svc.Directory is undefined" {file: "resource://services-sync/util.js" line: 337}]' when calling method: [nsITimerCallback::notify]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************

Looks like perhaps our code is running during shutdown?

However, the URI error was happening pretty much at startup. CrossWeave completes if I wrap those log statements in try/catch. *sigh*
Attached patch Proposed patch. v1 (obsolete) — — Splinter Review 
Haven't tested with (currently b0rked) TPS.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #536171 - Flags: review?(philipp)
Goddamn.
Attachment #536171 - Attachment is obsolete: true
Attachment #536171 - Flags: review?(philipp)
Attachment #536172 - Flags: review?(philipp)
Attachment #536172 - Flags: review?(philipp) → review+
Pushed:

https://hg.mozilla.org/services/services-central/rev/291b668fc690
Whiteboard: [fixed in services][qa-]
Attached image screenshot — 
I've found the following error on this beta:
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:5.0)Gecko/20110527
Firefox/5.0 Fennec/5.0
Device: HTC Desire
OS: Android 2.2

Error: Channel.URI is undefined
Source file: resource://services-sync/resource.js   Line:552

Is it related to this issue?
Looks like it.
http://hg.mozilla.org/mozilla-central/rev/291b668fc690
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.