656708 - Channel.URI is undefined during TPS run

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "channel.URI is undefined" {file: "resource://services-sync/resource.js" line: 546}]' when calling method: [nsIStreamListener::onStopRequest]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************

Comment 1

[Richard Newman [:rnewman]]

Yeah, this isn't supposed to happen; we never create a channel without a URI.

CrossWeave ends up dumping a lot of errors like this to the log:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "Svc.Directory is undefined" {file: "resource://services-sync/util.js" line: 337}]' when calling method: [nsITimerCallback::notify]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************

Looks like perhaps our code is running during shutdown?

However, the URI error was happening pretty much at startup. CrossWeave completes if I wrap those log statements in try/catch. *sigh*

Comment 2

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Haven't tested with (currently b0rked) TPS.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v2

Goddamn.

Comment 4

[Richard Newman [:rnewman]]

Pushed:

https://hg.mozilla.org/services/services-central/rev/291b668fc690

Comment 5

[Cristian Nicolae (:xti)]

Attachment: screenshot

I've found the following error on this beta:
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:5.0)Gecko/20110527
Firefox/5.0 Fennec/5.0
Device: HTC Desire
OS: Android 2.2

Error: Channel.URI is undefined
Source file: resource://services-sync/resource.js   Line:552

Is it related to this issue?

Comment 6

[Philipp von Weitershausen [:philikon]]

Looks like it.

Comment 7

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/291b668fc690