6 years ago
Maybe this is intentional behavior by Bug 519144 .
No, opacity:0 elements should get events.
OK Regression window: Works: http://hg.mozilla.org/mozilla-central/rev/5f0bd7129549 Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091026 Minefield/3.7a1pre ID:20091026045849 Fails: http://hg.mozilla.org/mozilla-central/rev/2e01e97f9ded Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091027 Minefield/3.7a1pre ID:20091027043823 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5f0bd7129549&tochange=2e01e97f9ded Suspected bug: cset 27c92be3d840 of Bug 519144.
Possible, but that patch _is_ checking IsForEventDelivery()...
Perhaps we hid the plugin and/or its widget and so it doesn't get any events because of that?
We hide its widget, I bet that's why it doesn't get mouse clicks. I guess where we check IsForEventDelivery we should actually check !IsForPainting.
Created attachment 532587 [details] [diff] [review] fix
Roc pushed this patch on cedar and it has been backed out because it's suspected of creating a perma-orange on Windows Mochitest-4: http://tinderbox.mozilla.org/showlog.cgi?log=Cedar/1305628182.1305628854.5624.gz&fulltext=1
It looks like this patch was the guilty one.
So the reason the tests failed is that there is an opacity:0 element covering these test plugins! It's the hidden statuspanel, which apparently has been hidden by making it opacity:0. Dao, any particular reason why you don't make it display:none instead? That would reduce overhead.
Created attachment 533541 [details] [diff] [review] fix v2 Ensure opacity:0 chrome elements are not treated as opaque when computing plugin visibility (change to TreatAsOpaque). Note that plugins in opacity:0 chrome elements would still work for accepting events, if anyone was crazy enough to want to do that. Passes the tests that failed previously.
(In reply to comment #10) > Dao, any particular reason why you don't make it display:none instead? That > would reduce overhead. display:none isn't being used in order to allow the status panel to fade in (using -moz-transition and opacity).
Comment on attachment 533541 [details] [diff] [review] fix v2 Looks like the contents of your test file got lost in this patch. You might want to look into that and make sure the test gets in.
I suspect this case is rare enough that we don't need to push the fix into FF5.