656767 - Reset password flow fails and ends with message about escaped dinosaurs

Status: VERIFIED FIXED

(Cloud Services :: Server: Account Portal, defect)

Description

[Tracy Walker [:tracy]]

Seen against stage with s-c build

STR's:
0) have an account setup on stage
1) Attempt to add a client to that account via full method (not easy setup)
2) enter incorrect password and correct key. Continue.
3) At message for incorrect password, click the link to reset password
4) Follow instructions through email retrieval and update the password.

Tested results:
Once complete the password is not reset and the page sames something about escaped dinosaurs and to try again later.

Expected results:
Password is changed and a page is displayed indicating such.


I saw this last week during testing and brought it up in IRC. server ops guys did some quick change and it worked as expected.  Is some config getting reset on stage?

Comment 1

[:Atoll]

The email sent to the user includes a URI argument "key" that is not accepted by AP when completing the transaction.  I did a lot of work on the staging Zeus tonight, so I'd like a second opinion.  Thoughts?  (Otherwise my smoke test worked fine.)

- email i received is below.

- rpm versions on ap.mtv1.stage: accountportal-1.0-1, services-1.2-1

- traceback from ap.mtv1.stage:/var/log/accountportal.log:

2011-05-12 02:14:29,092 ERROR [accountportal] Traceback (most recent call last):
 File "/usr/lib/python2.6/site-packages/services/util.py", line 452, in __call__
   return self.app(environ, start_response)
 File "/usr/lib/python2.6/site-packages/beaker/middleware.py", line 152, in __call__
   return self.wrap_app(environ, session_start_response)
 File "/usr/lib/python2.6/site-packages/webob/dec.py", line 147, in __call__
   resp = self.call_func(req, *args, **self.kwargs)
 File "/usr/lib/python2.6/site-packages/webob/dec.py", line 208, in call_func
   return self.func(req, *args, **kwargs)
 File "/usr/lib/python2.6/site-packages/accountportal/wsgiapp.py", line 171, in __call__
   result = function(request, **params)
 File "/usr/lib/python2.6/site-packages/accountportal/controllers/console.py", line 167, in forgot
   if not self.auth.update_password(user_id, password, key=code):
TypeError: update_password() got an unexpected keyword argument 'key'

- R.

Begin forwarded message:

From: [e-mail]@sreg1.mtv1.stage.svc.mozilla.com
Date: May 12, 2011 2:12:08 AM PDT
To: [e-mail]@sreg1.mtv1.stage.svc.mozilla.com
Subject: Resetting your Sync password

You asked to reset your Sync password. To do so, please click this link:

  https://stage-account.services.mozilla.com/forgot?username=b4ica4ry5mrk6wae57mkbyprecwvwdlo&key=REMO-VEDS-ORRY-YALL


This will let you change your password to something new. If you didn't ask for this, don't worry, we'll keep your password safe.


Best Wishes
The Services Team

Comment 2

[Toby Elliott [:telliott]]

Attachment: changes the function name in ap

Name of the function needs to change in a-p

Comment 3

[Toby Elliott [:telliott]]

Fixed in http://hg.mozilla.org/services/account-portal/rev/5839b0161724

Comment 4

[Tracy Walker [:tracy]]

Verified against stage a-p