656815 - javascript: URIs refuse to load when channel owner is null

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

See bug 656433 comment 19 and subsequent comments. Once we disallow inheriting of principals for URIs entered in the location bar, it would be nice to continue to allow javascript URIs that simply produce output to continue to work, by having them run against a null principal.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This seems to work (tested with the patch from bug 656433). Is it going to cause any security problems? I don't know!

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 532084 [details] [diff] [review]
patch

We actually depend on this code being the way it is to avoid running JS (even in a sandbox) in some contexts.  I'd rather not change that behavior right now.

For the bug 656433 thing, we'd want to get a null principal in docshell only.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

As discussed on IRC.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch, with tests

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 532274 [details] [diff] [review]
patch, with tests

r=me

Comment 6

[Brendan Eich [:brendan]]

Appreciate this followup work -- my javascript: typing habits thank you!

/be

Comment 7

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/2c977d6f8a75

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Note that there's still a slight annoyance here: the JS loaded in this scenario still won't have an associated window object, so thing like e.g. "javsacript:alert(1+1)" still won't work. We should probably get a followup filed to run them against about:blank somehow.