The default bug view has changed. See this FAQ.

Disable drawing of shadows with non-OVER operators

RESOLVED FIXED in mozilla7

Status

()

Core
Canvas: 2D
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

({dev-doc-complete})

Trunk
mozilla7
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2011-May/031594.html

I think this is the way the spec should go and I think it's very unlikely to affect Web compatibility.
Created attachment 532118 [details] [diff] [review]
fix
Attachment #532118 - Flags: review?(joe)
Created attachment 533234 [details] [diff] [review]
fix v2

Update test_canvas.html to disable tests that assume shadows work with non-over operators.
Attachment #532118 - Attachment is obsolete: true
Attachment #532118 - Flags: review?(joe)
Attachment #533234 - Flags: review?(joe)
Comment on attachment 533234 [details] [diff] [review]
fix v2

Review of attachment 533234 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/nsCanvasRenderingContext2D.cpp
@@ +534,5 @@
>      {
>          ContextState& state = CurrentState();
>  
>          // The spec says we should not draw shadows when the alpha value is 0,
>          // regardless of the operator being used.

You could update this comment if you wanted to
Attachment #533234 - Flags: review?(joe) → review+
Whiteboard: [needs landing]
http://hg.mozilla.org/projects/cedar/rev/22ec5982eca7
Whiteboard: [needs landing] → [fixed-in-cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/22ec5982eca7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla7
Version: unspecified → Trunk
Keywords: dev-doc-needed
Actually I didn't add a testcase specifically for this behavior, and I should have.
Flags: in-testsuite+ → in-testsuite?
Created attachment 536196 [details] [diff] [review]
Testcase
Attachment #536196 - Flags: review?(joe)
Bas, you might want to check that Azure behaves correctly with this test/behavior change.
Comment on attachment 536196 [details] [diff] [review]
Testcase

Review of attachment 536196 [details] [diff] [review]:
-----------------------------------------------------------------

i like this especially for spelling colour correctly
Attachment #536196 - Flags: review?(joe) → review+
Whiteboard: [needs landing]
http://hg.mozilla.org/integration/mozilla-inbound/rev/a565838cfc3a
Flags: in-testsuite? → in-testsuite+
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/a565838cfc3a
Documentation updated:

https://developer.mozilla.org/en/Canvas_tutorial/Applying_styles_and_colors#Shadows

And mentioned on Firefox 7 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.