656878 - nsStringArraySH::GetProperty copies string to js, but it could probably share it

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: testcase

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: wip

Uploaded to tryserver.

While I was looking at this code, I removed one QI in nsDOMTokenListSH::GetStringAt.

We may want to add some helper method which does all the ForgetSharedBuffer
thing. Or perhaps the last parameter of ReadableToJSVal should be
boolean to indicate whether it is ok to call ForgetSharedBuffer.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: without QI change

The QI removal doesn't apparently work, so this is just about the
string handling optimization.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(The QI optimization fails because I forgot the code is used also for nsDOMSettableTokenList)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 532206 [details] [diff] [review]
without QI change

r=me

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/5d5f2f15037b