Closed Bug 656878 Opened 9 years ago Closed 9 years ago
String Array SH::Get Property copies string to js, but it could probably share it
Uploaded to tryserver. While I was looking at this code, I removed one QI in nsDOMTokenListSH::GetStringAt. We may want to add some helper method which does all the ForgetSharedBuffer thing. Or perhaps the last parameter of ReadableToJSVal should be boolean to indicate whether it is ok to call ForgetSharedBuffer.
The QI removal doesn't apparently work, so this is just about the string handling optimization.
(The QI optimization fails because I forgot the code is used also for nsDOMSettableTokenList)
Comment on attachment 532206 [details] [diff] [review] without QI change r=me
Attachment #532206 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.